librephotos: When returning faces to unknown Scrolling down leaves empty spaces and invalid page

πŸ› Bug Report

  • πŸ“ I’ve Included a ZIP file containing my librephotos log files
  • ❌ I have looked for similar issues (including closed ones)
  • 🎬 (If applicable) I’ve provided pictures or links to videos that clearly demonstrate the issue

πŸ“ Description of issue:

When I go to the face tab and in the inferred tab change the assignment of more than X number of pictures, when scrolling down I get empty spaces and a pop-up that says Invalid Page until I refresh.

πŸ” How can we reproduce it:

Go to faces page, do more than a few rows of changes, and continue scrolling. Sometimes if the faces are not grouped together it happens more often, so if it’s not the whole row.

Please provide additional information:

  • πŸ’» Operating system: TrueNAS
  • βš™ Architecture (x86 or ARM): x86
  • πŸ”’ Librephotos version: Latest Stable
  • πŸ“Έ Librephotos installation method (Docker, Kubernetes, .deb, etc.): Docker
    • πŸ‹ If Docker or Kubernets, provide docker-compose image tag:
  • πŸ“ How is you picture library mounted (Local file system (Type), NFS, SMB, etc.): Direct Mount
  • ☁ If you are virtualizing librephotos, Virtualization platform (Proxmox, Xen, HyperV, etc.):

About this issue

  • Original URL
  • State: open
  • Created a year ago
  • Comments: 25 (6 by maintainers)

Most upvoted comments

I get this too. I am having a strange issue with tagging faces. When I navigate to the Faces->Inferred tab, I see the faces to infer. I tag a few faces and then I get an error message and looking at the dev tools I see that person 491 page 2 is failing. But the strange thing is that just before it - the request was successful. Only after tagging and only for this person 491 page 2 I get the error. This in itself not a problem, but the result is that all faces vanish and I cannot tag any more, only a browser refresh brings them back, until the next tag…

This effectively makes tagging a nightmare 😦

Console error log:

fetchBaseQuery.ts:40 
        
        
       GET http://192.168.1.4:3000/api/faces/?person=491&page=2&inferred=true&order_by=confidence 404 (Not Found)
Jg @ fetchBaseQuery.ts:40
(anonymous) @ fetchBaseQuery.ts:281
(anonymous) @ apiState.ts:34
(anonymous) @ apiState.ts:34
i @ apiState.ts:34
Promise.then (async)
s @ apiState.ts:34
(anonymous) @ apiState.ts:34
Gg @ apiState.ts:34
(anonymous) @ fetchBaseQuery.ts:215
(anonymous) @ api.ts:86
d @ regeneratorRuntime.js:44
(anonymous) @ regeneratorRuntime.js:125
(anonymous) @ regeneratorRuntime.js:69
r @ asyncToGenerator.js:3
s @ asyncToGenerator.js:22
(anonymous) @ asyncToGenerator.js:27
(anonymous) @ asyncToGenerator.js:19
(anonymous) @ api.ts:81
(anonymous) @ buildThunks.ts:390
(anonymous) @ apiState.ts:34
(anonymous) @ apiState.ts:34
(anonymous) @ apiState.ts:34
Gg @ apiState.ts:34
u @ buildThunks.ts:363
(anonymous) @ createAsyncThunk.ts:637
(anonymous) @ index.js:32
(anonymous) @ index.js:32
(anonymous) @ index.js:32
Jv @ index.js:32
(anonymous) @ createAsyncThunk.ts:599
Object.assign.pending @ createAsyncThunk.ts:599
(anonymous) @ index.js:16
dispatch @ redux.js:691
(anonymous) @ buildInitiate.ts:354
(anonymous) @ index.js:16
(anonymous) @ FaceDashboard.tsx:100
(anonymous) @ FaceDashboard.tsx:95
ou @ react-dom.production.min.js:244
kl @ react-dom.production.min.js:286
(anonymous) @ react-dom.production.min.js:283
xl @ react-dom.production.min.js:281
ll @ react-dom.production.min.js:273
Ho @ react-dom.production.min.js:127
(anonymous) @ react-dom.production.min.js:267

See screen capture here: https://www.kapwing.com/w/fx_AqJiibc I tried re-scanning the library, that didnt help

I checked the DB - person 491 is a valid person (not an unknown cluster), so not sure how to pinpoint the face that causes issues…

Logs from the logs folder: logs.zip

I understand this is hard to reproduce - so I am happy to try and debug this locally, if you can provide instructions on where to look

Nice, seems to work much better now, still sometimes you need to scroll up or down or toggle sorting Confidence/Date to make some faces to show up after tagging a face in Inferred tab

@derneuere Preliminary tests on empty enferred collection - no error! Yay! I’m gonna start a new image scan and check again when there are inferred faces and report back.

Looks promising! 🀞

Yes exactly πŸ˜ƒ

For now only on dev or in the next release in January πŸ˜ƒ

Still present in the latest version.

Looks like the counting for unknown faces was just broken in general. Fixed a push and that will be in the next release πŸ˜ƒ