lerna: Orphaned child processes keep running when exiting `lerna run` with an error

I saw this issue’s fix PR has been merged but not released, when is the next release, BTW last release was 7 months ago 😐

We tested this version with our repository and it caused other issues of the process continually respanwning.

Downgrading to Lerna 3.22.1 seems to fix this issue. For now anyone who wants to use Lerna in a Windows environment should probably lock their dependency to that version.

any update? facing the issue on windows 11 with lerna 4.0.0

I saw this issue’s fix PR has been merged but not released, when is the next release, BTW last release was 7 months ago 😐

We tested this version with our repository and it caused other issues of the process continually respanwning.

Downgrading to Lerna 3.22.1 seems to fix this issue. For now anyone who wants to use Lerna in a Windows environment should probably lock their dependency to that version.

I’m using lerna run --parallel dev to run a local nodejs dev server and vite in GitBash windows. The problem for me what that vite was never killed and continued to block the TCP port.

Reverting to 3.22.1 also fixed it for me. Shame this is not fixed. What are the alternatives to Lerna if it’s no longer maintained?

I’ve dug into this pretty deeply and I have a simple reproduction finally, the issue linked above has all of the steps but there is one extra for Lerna:

Follow the Steps here: https://github.com/apollographql/apollo-server/issues/4097

Including uncommenting the line of code to call await stop(). Once the server restarts the child process becomes orphaned, then do ctrl+c in your terminal to kill Lerna .

Observe in the browser that network requests continue successfully while the process should be shut down entirely.

Restarting Lerna with npm start causes everything to startup fine but no network requests are recieved, a background orphaned process is receiving them. If you change the behavior of the code at all, the results of the network requests appear unchanged.

So the process chain is something like:

npm -> lerna -> npm -> tsc-watch -> node

The bottom most node process becomes orphaned when it doesn’t shut down after receiving the SIGTERM signal from tsc-watch and then later when lerna is killed it doesn’t ensure that all child processes are also shut down.

We waited literally 3 years for that 1 line fix 🤣

@magalhas This is likely not getting solved. Lerna is an abandoned project.

Thanks all!

This should hopefully be fixed by @feryardiant change, applied in https://github.com/lerna/lerna/pull/3156

Same here, considering Lerna is changing hands, maybe we can revive this issue @Nrwl ?

Was stuck on this for 4 hours. Express server kept giving EADDRINUSE errors since Lerna wasn’t terminating the Node server child processes…3.22.1 downgrade has resolved this

Is this getting solved? Facing the same issue using Windows + MINGW64

I see. Was hoping there was some solution without WSL/Bash :\

@evocateur please take a look at sindresorhus/execa#433 when you get a chance. Looks like there are some options for this.

I’m guessing this repo has gone dark essentially in favor of the built-in “workspaces” feature in npm now:

https://docs.npmjs.com/cli/v8/using-npm/workspaces

same issue here, windows 10, lerna 4.0.0, parallel.

In the latest version of lerna I’ve been having success using WSL and in my npm start script I’m doing something like:

{
  "scripts": {
    "start": "./start.sh"
  }
}

Then in the start script I’m using a trap to kill child processes:

#!/bin/bash
# start.sh
onexit() {
  for p in "${pids[@]}" ; do
    kill "$p";
  done
}

# Lerna sends a signal which the trap receives
trap onexit EXIT
pids=()

# Run as child processes
example &
pids+=($!)
# ...

# Wait for all child processes to exit
wait

Is there some workaround for this in the meanwhile, based on sindresorhus/execa#433?

Our workaround was to NOT change NPM’s script-shell, leaving it at the platform default. Then we change incompatible scripts on an as-needed basis using “bash -c ‘<script here>’” and pray we don’t run into issues.

We just ran into this and have figured out the conditions for reproducing:

1. Running on Windows (I launched lerna from Git Bash, I’m not sure whether this matters)
2. An npm script that loops. I can reproduce with ‘tsc -w’
3. The script must be executed via a sh or bash shell, either by changing NPM’s script-shell OR changing the script to be like: “bash -c ‘tsc -w’”. This does not occur with cmd shell that npm defaults to on Windows.
4. the Script must be executed via lerna, like: lerna run tscw --stream --scope my-package

This is a major roadblock to our team’s work as we have people running on multiple platforms and are trying to standardize our npm scripts to all run in bash.

Just an FYI, we are having the same issue with Lerna 3.20. I don’t know how too recreate, but if things slow down I will try to troubleshoot.