lerna: Can't seem to major version bump with conventional commits

Expected Behavior

BREAKING CHANGE in commit message should trigger a major version bump

Current Behavior

The following commit messages result only in patch bumps

feat: v2

BREAKING CHANGE
build: be more flexible on dependency versions (#76)

BREAKING CHANGE: v2.0.0 didn't ship with the intended commit womp womp
ci: update commitlint and commitlint related things (#77)

BREAKING CHANGES: please just release v2.0.0 now...
ci: bump lerna (#78)

Because why not?

BREAKING CHANGES: please just release v2.0.0, I'm begging you
fix: bump lerna (#79)

Eventually you're going to get bored and work

BREAKING CHANGE: please, just... please

Steps to Reproduce (for bugs)

  1. The code is available at https://github.com/emdaer/emdaer
  2. Otherwise, just do normal things that work with semantic release
lerna.json

{
  "lerna": "2.0.0-rc.5",
  "packages": [
    "packages/*"
  ],
  "npmClient": "yarn",
  "npmClientArgs": [
    "--production",
    "--no-optional"
  ],
  "version": "1.8.9"
}

Context

We have a pile of patches that need to be deprecated because they contain breaking changes

Your Environment

Executable Version
lerna --version 2.9.0
npm --version 5.5.1
yarn --version 1.3.2
node --version 8.9.0

About this issue

  • Original URL
  • State: closed
  • Created 6 years ago
  • Reactions: 1
  • Comments: 15 (6 by maintainers)

Most upvoted comments

A conventional breaking change still needs a subject line with either “fix:” or “feat:” then two newlines (a new paragraph, the “body” of the commit message) before the “BREAKING CHANGE:” description.

On Mar 12, 2018, at 07:52, Justin Conway notifications@github.com wrote:

Also having this issue on a brand new repo. Not doing anything crazy, just added the repo, added lerna to the root, created a package and made a commit message of BREAKING CHANGE: foo and ran lerna publish --conventional-commits --skip-npm --yes and it won’t bump major versions:

However feat: foo commits will give me a minor version bump.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.