leftwm: AUR PKGBUILDs use incorrect systemd detection

Describe the bug

Both the leftwm and leftwm-git PKGBUILDs incorrectly use ps to detect if we should build for systemd. This is incorrect because when building in a clean chroot (as is expected for Arch packaging in general), systemd is not necessarily running, even if the target system does in fact use systemd. We may also utilise a non-systemd system to build packages for a systemd target.

Expected behavior (optional)

The PKGBUILD should be split into separate packages so that the user can choose which one they want to install.

Steps to reproduce (optional)

No response

Relevant log output (optional)

No response

OS / Distro

Arch Linux

Additional System Information (optional)

No response

LeftWM Check

n/a, as this is reporting an issue with build scripts

About this issue

Original URL
State: closed
Created a year ago
Comments: 17 (7 by maintainers)

Most upvoted comments

Sure, I’ll write up a patch for the other package, just wanted to confirm if you were happy with the changes. I’ll post the other patch within a couple days.

eclairevoyant on Jun 9, 2023

Sure, I can handle those. I’ll post a patch that can be applied with git am (i.e. it would mark me as the author and you as the committer). Unfortunately AUR does not have PR/MR functionality atm

eclairevoyant on May 30, 2023

Just to give concrete examples of PKGBUILDs:

If you go the signed tag route: https://github.com/eclairevoyant/aur-packages/blob/main/python-aiomultiprocess/PKGBUILD
If you go the signed tarball route: https://github.com/eclairevoyant/aur-packages/blob/main/zrythm/PKGBUILD

eclairevoyant on Jun 19, 2023

Is your proposal to make a package split similar to how you did with eww-git?

Yes, since (from a maintainer point of view) I think that would be easier compared to maintaining completely separate PKGBUILDs for systemd vs non-systemd. I’m happy to suggest a patch if you’re open to this.

eclairevoyant on May 30, 2023