ledger-live: [Bug]: signEIP712Message result error

Impacted Library name

@ledgerhq/hw-app-eth

Impacted Library version

6.34.9

Describe the bug

  1. In some cases the signature result does not match the signEIP712HashedMessage
  2. The device reports Invalid data received(0x6a80) when signing withsignEIP712Message in lower versions of hw-app-eth.
 {
  types: {
    BatchSignedERC721Orders: [
      { type: 'address', name: 'maker' },
      { type: 'uint256', name: 'listingTime' },
      { type: 'uint256', name: 'expiryTime' },
      { type: 'uint256', name: 'startNonce' },
      { type: 'address', name: 'erc20Token' },
      { type: 'address', name: 'platformFeeRecipient' },
      { type: 'BasicCollection[]', name: 'basicCollections' },
      { type: 'Collection[]', name: 'collections' },
      { type: 'uint256', name: 'hashNonce' }
    ],
    BasicCollection: [
      { type: 'address', name: 'nftAddress' },
      { type: 'bytes32', name: 'fee' },
      { type: 'bytes32[]', name: 'items' }
    ],
    Collection: [
      { type: 'address', name: 'nftAddress' },
      { type: 'bytes32', name: 'fee' },
      { type: 'OrderItem[]', name: 'items' }
    ],
    OrderItem: [
      { type: 'uint256', name: 'erc20TokenAmount' },
      { type: 'uint256', name: 'nftId' }
    ],
    EIP712Domain: [
      { name: 'name', type: 'string' },
      { name: 'version', type: 'string' },
      { name: 'chainId', type: 'uint256' },
      { name: 'verifyingContract', type: 'address' }
    ]
  },
  domain: {
    name: 'ElementEx',
    version: '1.0.0',
    chainId: '5000',
    verifyingContract: '0x2fa13cf695ec51ded5b8e45ad0bef838ab17e2af'
  },
  primaryType: 'BatchSignedERC721Orders',
  message: {
    maker: '0x6d3b90747dbf5883bf88ff7eb5fcc86f408b5409',
    listingTime: '1706688449',
    expiryTime: '1709280466',
    startNonce: '7',
    erc20Token: '0x09bc4e0d864854c6afb6eb9a9cdf58ac190d0df9',
    platformFeeRecipient: '0x7538262ae993ca117a0e481f908209137a4626e',
    basicCollections: [
      {
        nftAddress: '0xaaaea1fb9f3de3f70e89f37b69ab11b47eb9ce6f',
        fee: '0x000000000000000000c80000000000000000000000000000000000000000000',
        items: [
          '0x000000000000000020c8558000000000000000000000000000000000000005d'
        ]
      }
    ],
    collections: [],
    hashNonce: '0'
  }
};
image

Expected behavior

Using signEIP712Message and signEIP712HashedMessage should result in the same signature.

Additional context

Online demo https://codesandbox.io/p/github/heisenberg-2077/ledger-signEIP712Message

About this issue

  • Original URL
  • State: open
  • Created 5 months ago
  • Comments: 16 (11 by maintainers)

Commits related to this issue

Most upvoted comments

@0x398 you are not part of the organization, please contact a maintainer if you need to run this command.

it was not a command…

not stale