lumen-framework: [Bug] Request parameters lost when unit testing

I’m not sure why but putting app(Request::class); before the test is run seems to resolve the problem:

<?php

use Illuminate\Http\Request;

abstract class TestCase extends Laravel\Lumen\Testing\TestCase
{
    /** @var  \Faker\Generator */
    protected $faker;

    /**
     * Creates the application.
     *
     * @return \Laravel\Lumen\Application
     */
    public function createApplication()
    {
        return require __DIR__.'/../bootstrap/app.php';
    }

    public function setUp()
    {
        parent::setUp();
        app(Request::class);
    }
}

Hello, I have same problem using latest lumen version.

My code in test:

$this->headers = [
    'HTTP_ACCEPT' => 'application/vnd.' . env('API_VENDOR', '') . '.v1+json',
    'HTTP_AUTHORIZATION' => 'Bearer ' . $jwt
];
$request = $this->get('api/user?access_token='.$jwt, $this->headers);

both header and query params are lost. can you help me?

Hi, Lumen 5.4.7 affected. Same issue with both json and post IF you’re type checking against anything other than \Illuminate\Http\Request in your controller

I have the same problem with query parameters. (Lumen 5.3)

I’m using Lumen 5.2.9 and in my tests i’m also experiencing the problem that my query parameters get lost. $getResponse = $this->call( 'GET', '/v1/users/me?include=matches', [], [], [], $this->token ); and also when using the call like this $getResponse = $this->call( 'GET', '/v1/users/me', ['includes' => 'matches'], [], [], $this->token );

I’m using replace request params in TestCase.php

    /**
     * Call the given URI and return the Response.
     *
     * @param  string  $method
     * @param  string  $uri
     * @param  array   $parameters
     * @param  array   $cookies
     * @param  array   $files
     * @param  array   $server
     * @param  string  $content
     * @return \Illuminate\Http\Response
     */
    public function call($method, $uri, $parameters = [], $cookies = [], $files = [], $server = [], $content = null)
    {
        //Fix issue with request params not existent
        $this->currentUri = $this->prepareUrlForRequest($uri);

        $symfonyRequest = SymfonyRequest::create(
            $this->currentUri, $method, $parameters,
            $cookies, $files, $server, $content
        );

        /**@var Request $request*/
        $request = $this->app['request'] = Request::createFromBase($symfonyRequest);
        $request->replace($parameters);

        return $this->response = $this->app->prepareResponse(
            $this->app->handle($this->app['request'])
        );
    }

@cdarken since this issue is 4 years old I think it’s better to open a new issue with new steps of replication on a fresh laravel 5.6 app.

This issue shouldn’t be closed. It persists to this day in the most recent version of Lumen.

This appears to be an ongoing issue even within Laravel 5.5.

Although, in my instance, I may have narrowed the problem down to the fact that phpunit isn’t actually performing any http requests and is instead calling parts of the system directly. (Please don’t quote me on that though).

I came across this when I noticed the below block being skipped over for phpunit tests:

   public function __construct(Request $request)
   {
        if (!\App::runningInConsole()) 
        {
            // Never accessed
        });

I have this check on almost every single one of my controllers to prevent artisan (route:list springs to mind straight away) from picking up __constructs() in it’s calls.

Downside to this is that checking php_sapi_name() as per

\Illuminate\Foundation\Application::runningInConsole()

shows “cli” which of course isn’t overly unique. I’m not sure if there is a clean way to determine if phpunit is the calling process but this will most likely solve plenty of issues in my code.

I’m hoping this helps anybody (or somebody) narrow down the issue as it’s rather frustrating at present.

Same issue here with Lumen 5.5.2, only when testing:

// Sending a request from a test.

public function it_does_something()
{
    $this->json('GET', '/api/v1/something', [
        'from' => '2017-01-01',
        'to'   => '2017-12-31',
    ]);
}

// Dumping from my JSON resource.

public function toArray($request)
{
    dd(
        // []
        $request->all,
        // ['from' => '2017-01-01', 'to'   => '2017-12-31']
        app('request')->all()
    );
}

Same issue with Lumen 5.5.2, type hinting child classes from Illuminate\Http\Request looses content, params, etc while testing API.

Opened another bug ticket: https://github.com/laravel/lumen-framework/issues/694

So after countless hours of debugging it turns out I narrowed the issue down to user error. I generated a blank project, recreated the controller by using php artisan make:controller then adding all the same methods and lo and behold it worked. So I diffed the two controllers.

My controller had the following line at the top:

use Illuminate\HTTP\Request;

The fresh one made by Laravel had:

use Illuminate\Http\Request;

As soon as I changed my controller to use the correct casing the reference resolved properly. This was a valuable lesson for sure, and I’m not sure how this was never caught before.

@jobnomade Did you ever find a workaround for this?

Thanks. Would be good to see if anyone is working on this. I mean it is a lightweight framework to build microservices. And we can’t even test a request on the console?

@jobnomade The last ticket about this issue, that i can find, is from december 2017.

I certainly seem to be experiencing similar issues to this. I’ve explained in more detail at https://stackoverflow.com/questions/49856295/laravel-phpunit-test-with-json-request-loses-important-request-details

I really don’t understand how this can be happening without breaking considerably more of my code.

Solved the same issue - in my case problem was with test data because json_encode returned FALSE.

You can see this function in the MakesHttpRequests.php:

    public function json($method, $uri, array $data = [], array $headers = [])
    {
        $content = json_encode($data);
        $headers = array_merge([
            'CONTENT_LENGTH' => mb_strlen($content, '8bit'),
            'CONTENT_TYPE' => 'application/json',
            'Accept' => 'application/json',
        ], $headers);
        $this->call(
            $method, $uri, [], [], [], $this->transformHeadersToServerVars($headers), $content
        );
        return $this;
    }

And the first thing it’s doing is json_encode array with testing data to be posted. So I fixed my test scenario data so that json_encode is no more FALSE and now tests works fine.

@lzpfmh Still noticing the issue in 5.4.4

The issue is that MakesHttpRequests::call does not create a request using createFromBase which would load the json params. #577 fixes it.

Same goes for Lumen 5.4.0. The request doesn’t seem to have anything bound to it. When I try to test an API endpoint with the following testcase:

<?php


class GroupControllerTest extends \TestCase
{
    public function testCreateGroup()
    {
        $account = $this->faker->uuid;
        $this->json('POST', "/v1.0/$account/groups", $data = [
            'name' => $this->faker->name
        ]);

        $this->seeJsonContains($data);
        $this->assertResponseStatus(201);
    }
}

The request seems to be empty inside the actual controller.

<?php
namespace App\Http\Controllers;

class GroupsController extends Controller
{
    public function create(Request $request, $account)
    {
       // $request->all() is an empty array
        return response()->json($request->all(), Response::HTTP_CREATED);
    }
}

same here. query parameters lost, header parameters lost, POST end up in GET, … (lumen 5.3.3)