framework: Config dependency problem
- Laravel Version: 5
- PHP Version: 7
- Database Driver & Version: N/A
Description:
src/Illuminate/Notifications/resources/views/email.blade.php
contains a reference to the global config
function, which only occurs in the whole framework, thus breaking the notations package when used outside of the framework.
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Reactions: 1
- Comments: 16 (15 by maintainers)
I’d also prefer a solution where
illuminate/config
isn’t a requirement. The less dependencies the better and requiring it just for this reason is a bit too much. I’d also mean people will have to set it up when using this package separately.Maybe a hardcoded value for
app.name
would be for the best for now but I don’t know what to do aboutconfig('app.url')
…