framework: Cannot generate an app key if session is encrypted and a response macro exists

• Laravel Version: 5.4.32
• PHP Version: 7.0.18
• Database Driver & Version: n/a

Description:

An application with these three things:

• session.encrypt config set to true
• A response macro registered in a service provider boot method
• No application key (e.g. because you’ve just cloned an existing application from your team’s version control).

You cannot run any Artisan commands (including key:generate) because you get the following error:

[RuntimeException]                                                                        
The only supported ciphers are AES-128-CBC and AES-256-CBC with the correct key lengths. 

Looking at the stack trace it’s because resolving the responses factory to register the macro results in the following being resolved out of the container:

1. The redirect service…
2. Which is injected with the session.store…
3. session.store calls driver() on the session immediately
4. Which results in the encrypted session being created, injected with the encrypter: https://github.com/illuminate/session/blob/master/SessionServiceProvider.php#L47

As well as causing the above problem, this also all seems very costly just to register a response macro. I’m thinking somewhere in the chain something needs to be injected with the container and only resolve the things it needs when it actually needs them. My suggestion would be the responses factory or the redirector.

If you advise what in the chain should change, I’d be willing to work on a PR for a fix.

Steps To Reproduce:

1. Create a brand new Laravel application
2. Remove the application key
3. Set session.encrypt to true
4. Add the following to your AppServiceProvider::boot() method:

    public function boot()
    {
        Response::macro('caps', function ($value) {
            return Response::make(strtoupper($value));
        });
    }