framework: Artisan generated resource controller vars don't match resource route params when model has multiple words.

Laravel Version: 5.4.13

Description:

When using Artisan to generate a model (and resource controller) with multiple words, the route param doesn’t match the var names used in the controller.

The route param ends up snake case, while the var names are camel case.

Steps To Reproduce:

artisan make:model -mcr ProductionOrder

// routes/web.php
Route::resource('production-orders', 'ProductionOrderController');

// app/ProductionOrder.php (generated by Artisan)
public function show(ProductionOrder $productionOrder) {};

// wherever.php
dd(Route::getRoutes());
// #allRoutes: array:8 [
//   "HEADapi/user" => Illuminate\Routing\Route {#250}
//   "HEADproduction-orders" => Illuminate\Routing\Route {#240}
//   "HEADproduction-orders/create" => Illuminate\Routing\Route {#239}
//   "POSTproduction-orders" => Illuminate\Routing\Route {#238}
//   "HEADproduction-orders/{production_order}" => Illuminate\Routing\Route {#237}
//   "HEADproduction-orders/{production_order}/edit" => Illuminate\Routing\Route {#236}
//   "PATCHproduction-orders/{production_order}" => Illuminate\Routing\Route {#235}
//   "DELETEproduction-orders/{production_order}" => Illuminate\Routing\Route {#234}
// ]

About this issue

Original URL
State: closed
Created 7 years ago
Reactions: 1
Comments: 15 (5 by maintainers)

Most upvoted comments

In addition to snapey’s answer, you can also use dashes in the resource method and it’ll work just as usual.

Route::resource('my-route'), 'RouteController');

Route will expect {my_route} and controller will expect (MyRoute $myRoute) but it’ll work as usual. Seems like this is a new fix, since it didnt use to work.

istratos on Dec 26, 2017

Laravel magically will inject a initiated ProductOrder model with the id given in the url at the placeholder: {production_order} .

https://laravel.com/docs/5.4/controllers#resource-controllers

Naming Resource Route Parameters
By default, Route::resource will create the route parameters for your resource routes based on the "singularized" version of the resource name. You can easily override this on a per resource basis by passing parameters in the options array. The parameters array should be an associative array of resource names and parameter names:

Route::resource('user', 'AdminUserController', ['parameters' => [
    'user' => 'admin_user'
]]);
The example above generates the following URIs for the resource's show route:

/user/{admin_user}

ametad on Jul 18, 2017

@devcircus …because it doesn’t work as it should. See the first post.

artisan_generated_resource_controller_vars_don_t_match_resource_route_params_when_model_has_multiple_words__ _issue__18167_ _laravel_framework

@stefanoruth Yes, you can rename it, but the point of Artisan is to make things more convenient. It doesn’t just work when model names are multi-word in camel case.

As someone new to building Laravel apps, this is pretty confusing. It took me a long time to track down the problem, and even asking a more experienced Laravel dev was no help. Should be an easily-prevented problem. It’s obviously a simple mistake made when writing the code. No way whomever wrote it intentionally set something to send snake case but receive camel case.

curtisblackwell on Mar 5, 2017

Is there a problem with it not working or is it just the url formatting thats not fitting you? 😃

stefanoruth on Mar 3, 2017