framework: "app()->makeWith(..." does not work with "app()->instance(..."

You can bypass this with offsetSet:

app()->makeWith(Concrete::class, ['foo' => 'bar']);

// in test
app()->offsetSet(Concrete::class, $mock);

In case someone else is looking for this. You can mock it like this in your tests. Use bind() instead of instance()

   $orders_mock = \Mockery::mock(OrdersRequest::class)->makePartial();
   $orders_mock->shouldReceive('send')->andReturn($order_response);
   $this->app->bind(OrdersRequest::class, function() use ($orders_mock){
       return $orders_mock;
   });

And it will use the Mock.

1. Make does not support parameters in laravel 5.6

Yes, it does.

https://github.com/laravel/framework/blob/56a58e0fa3d845bb992d7c64ac9bb6d0c24b745a/src/Illuminate/Container/Container.php#L592-L602

@mfn, wow thank you very much! Never expected something that obvious! Will you believe I worked a full day on this one… So in essence @sisve was right, expecting an already cached instance of ApiService when he says:

My first thought is that you have already resolved and cached an AnotherService somewhere.

The order in your setUp is wrong:

• your first create an instance of AnotherService which uses ApiService so it will immediately create non-mocked instance of ApiService for that service
• only a line later your set your mocked instance

Switch the two lines and it should work.

My first thought is that you have already resolved and cached an AnotherService somewhere. Is it perhaps a singleton registered from within your service provider? Then it would keep using whatever reference to ApiService it had from the beginning, and not know about any mocked instances introduced in the Container at a later time.

I’m using mocked services in setUp all the time, no problems.

How does your setUp look exactly?

How does the code, which resolves the ApiService look like (or the constructor of AnotherService)?

Is there any news on this one?

What is going on? Why the issue is closed when the bug persists?

I think it should also ignore parameters if the instance is given.

This does not feel right.

Getting some kind of instance from the service container with dynamic parameters is always a bit of hybrid and can pose some challenges, one of them is the problem of mocking.

For tests, you can use a factory class which will then create your instance based on your parameters. Which means, you return a mock for the factory which then is responsible for creating your mocked actual class. Sounds a bit complex, but in practice it’s easy:

// Instead of
$instance = app()->makeWith(Concrete::class, ['your' => $args]);

// you can do
$instance = app(ConcreteFactory::class)->yourOwnMake($args);

You then mock ConreteFactory and return via yourOwnMake whatever you want, and it can also be dynamic based on your $args

1. Make does not support parameters in laravel 5.6

2. Laravel ignores differences between bind and singleton if there is an instance provided. It is working great for mocking. I think it should also ignore parameters if the instance is given. For mocking purposes the provided instance should be different from what is built using some parameters. Laravel does not care about instance that is set by app()->instance(..., it may be an instance of a different type, why should it care about parameters?