test-infra: prow: reply to PR with pass/fail status of merged postsubmit

Post-submit jobs that are tied to a PR should be able to post the results of the job back to the PR.

We do something similar for the updateconfig plugin, but job status (pass/fail) and a link to the job log should be something all postsubmits can do.

/kind feature

About this issue

Original URL
State: open
Created 6 years ago
Reactions: 7
Comments: 35 (25 by maintainers)

Most upvoted comments

Commits may or may not include a PR. I would prefer prow:
* Report postsubmit jobs to the commit, rather than the PR
  
  * This is already where we report the status

* Listen for comments added to the commit, allowing /retest, etc

* Potentially drop a note on the PR (once) noting that postsubmits were triggered at commit X
AKA the post submits for this PR: #21004 (comment) are associated with this commit: a0a857f that is where we should leave comments (where we already send status contexts) and where people should leave comments to trigger testing.

PR #17142 now covers the reporting part:

Postsubmits are reported to the corresponding commit
A one-time note is dropped to the PR (if a PR is associated with the commit)

Once the above PR hopefully gets merged I will open a separate PR to handle listening to commits/retesting, etc.

adshmh on Feb 10, 2022

We only need the comment on a failure, right?

stevekuznetsov on Aug 8, 2019

After https://github.com/kubernetes/test-infra/pull/11168, we will have postsubmit setting status context by default for all postsubmit jobs.

Currently the knative-postsubmit worked for test-infra repo. screenshot from 2019-02-06 14-38-46

Will implement comment on a commit & respond to trigger from a commit in the near future.

(It’s tied to each merge commit, instead back to PR itself, since postsubmit is triggered upon pushevents, and not necessarily all push will have a corresponding PR)

krzyzacy on Feb 8, 2019

yes, I’m trying to migrate reporter to crier first. https://github.com/kubernetes/test-infra/pull/10675 and https://github.com/kubernetes/test-infra/pull/10818 are moving towards that. Once that’s done technically we only need to enable Postsubmit to https://github.com/kubernetes/test-infra/blob/master/prow/github/reporter/reporter.go#L55 - will make a follow up PR in the week. (Friday afternoon? 😏 )

krzyzacy on Jan 21, 2019

Do you plan to provide retest functionality for postsubmit jobs from PR view?

aszecowka on Dec 14, 2018