test-infra: Prow: malformed prowjob should have been GCed

What happened:

A malformed prowjob that would have never been scheduled a pod due to a typo in cluster field, has been hanging around for more than 4 days, and prow-controller-manager keeps on reporting errors on this prowjob.

What you expected to happen:

The prowjob should have been GCed earlier, maybe the same as max pod age (48 hours)?

How to reproduce it (as minimally and precisely as possible):

Create a prowjob with cluster defined to be a cluster not exist.

Please provide links to example occurrences, if any:

Anything else we need to know?:

About this issue

  • Original URL
  • State: closed
  • Created 3 years ago
  • Comments: 17 (14 by maintainers)

Most upvoted comments

/reopen Presumably the “job with invalid cluster doesn’t get GCd” issue still exists

+1
alvaroaleman on Jan 28, 2021

The PJ was older than the max PJ age and sinker didn’t GC it. That does not seem to be WAI to me, why would we allow PJs to persist beyond the max PJ age in this scenario?

Ah, that wasn’t clear from the description. That is a bug in sinker then.

+1
alvaroaleman on Jan 26, 2021
Read more comments on GitHub
← test-infra: Prow jobs are failing with 'Could not resolve host: github.com'
test-infra: Prow plugin local test instruction doesn't work →