test-infra: plugin to block "fixes #123" in commit messages

this causes issues to repeatedly close when people merge into their forks, we should build a plugin to add a do-not-merge/* label to PRs that contain these types of strings in their commit messages

per discussion with @liggitt

/sig contributor-experience /sig testing /area prow /kind feature cc @cjwagner @stevekuznetsov

This is similar to the merge commits blocker https://github.com/kubernetes/test-infra/issues/5376

About this issue

Original URL
State: closed
Created 6 years ago
Reactions: 4
Comments: 17 (14 by maintainers)

Most upvoted comments

We do not

spiffxp@spiffxp-macbookpro:kubernetes (master %)$ git log --merges
commit 45c5ddd2fb8f10e097483257663fa6a7be59ffa9
Merge: 7bfd0d358c 55199a04be
Author: k8s-ci-robot <k8s-ci-robot@users.noreply.github.com>
Date:   Tue Sep 11 13:27:50 2018 -0700

    Merge pull request #68494 from k82cn/k8s_67606_2

    Added default tolerations for new pods.

spiffxp on Sep 12, 2018

Created a PR: https://github.com/kubernetes/test-infra/pull/9387

/remove-help

nikhita on Sep 13, 2018

from https://help.github.com/articles/closing-issues-using-keywords/

one of those keywords followed by [\s:]+(\w+/\w+)?#\d+

also, not sure if you want to track it with this or separately, but preventing nick mentions in commit descriptions would be a boon to anyone who gets a hundred emails when a commit mentioning them gets pulled into all the various forks of a repo

liggitt on Sep 12, 2018

@BenTheElder Re nick mentions: would this also mean that we would need to forbid @ mentions in the main PR body?

I think tide does not add the whole PR body in the merge commit message so this should not be needed but I’m not sure.

nikhita on Sep 12, 2018

preventing nick mentions in commit descriptions would be a boon to anyone who gets a hundred emails when a commit mentioning them gets pulled into all the various forks of a repo

+100. Let’s please make this happen!

nikhita on Sep 12, 2018