controller-runtime: DeleteCollection does not work with Limit and Continue list options
PR #341 is trying to add Limit and Continue list options for paging. But there’s no way to make it work with DeleteCollection because there is no way to grab the continue token returned by the server to delete the next page of things.
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Comments: 19 (16 by maintainers)
Commits related to this issue
- Merge pull request #548 from yangy2000/fix_typo Fix some typos — committed to kubernetes-sigs/controller-runtime by k8s-ci-robot 5 years ago
We can add limit and continue support to list options, and just not support the functional option variants on deletecollection calls. You’ll still be able to manally set them in the DeleteCollectionOptions struct if you really want, but if you do that, then you’ve explicitly gone out of your way to break yourself.