cluster-api-provider-aws: unknown field "emeritus_maintainers" in the OWNERS file

It can take some time before a tool like that becomes stable. I think what matters in this case is that there is no such field (_maintainers) defined in the YAML spec of the bot that reads the owners files. On Jan 28, 2022 11:58, “Gergely Brautigam” @.***> wrote:

Sorry, I didn’t mean to sound so pendantic. Just please help me understand the adoption process of a new tool in this ecosystem. 😊

— Reply to this email directly, view it on GitHub https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/3104#issuecomment-1024058253, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACRATBHTH4RG3MIN5LSRJDUYJSGFANCNFSM5M3BXBFQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.*** com>

@Skarlso - what do you think to this then:

• Remove emeritus_approvers
• Rename emeritus_maintainers to emeritus_approvers

I think we should still acknowledge emeritus reviewers/approvers in general. So how about we add a section in the README.md under the Our contributors heading (before the image of all the contributors) where we add something like Thank you to all our contributores and a special thank you to our emetritus maintainer: XXXXX and emeritus reviewers XXXXX?

There is only an _approvers field. Leaving the decisions to the current maintainers. On Jan 28, 2022 13:19, “Gergely Brautigam” @.***> wrote:

@neolit123 https://github.com/neolit123 Oh thank you! So. Umm… what do we change emeritus_reviewers into?

— Reply to this email directly, view it on GitHub https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/3104#issuecomment-1024119152, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACRATDXVNUB5O7RK4PTGLDUYJ3UXANCNFSM5M3BXBFQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.*** com>

@Skarlso - when you make this change could you move the existing emeritus_approvers into the emeritus_reviewers list? And then change emeritus_maintainers to emeritus_approvers?