aws-ebs-csi-driver: EBS CSI Driver helm charts are missing namespace information

/kind bug

What happened? The helm charts do not have namespace: {{ .Release.Namespace }} field. This causes the template to not have namespace when with helm template --namespace kube-system

What you expected to happen? Expected the namespace to be included in the generated manifests using helm

How to reproduce it (as minimally and precisely as possible)?

helm repo add aws-ebs-csi-driver https://kubernetes-sigs.github.io/aws-ebs-csi-driver
helm repo update

helm template aws-ebs-csi-driver \
    --namespace kube-system \
    aws-ebs-csi-driver/aws-ebs-csi-driver

Check the generated manifests, they would not have the namespace field.

Anything else we need to know?:

Environment

Helm version (version.BuildInfo{Version:"v3.4.1", GitCommit:"c4e74854886b2efe3321e185578e6db9be0a6e29", GitTreeState:"dirty", GoVersion:"go1.15.4"}):
Driver version: v1.1.0 (https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/CHANGELOG-0.x.md)

About this issue

Original URL
State: closed
Created 3 years ago
Comments: 16 (12 by maintainers)

Most upvoted comments

It isn’t ignored. It is used in the role bindings. I am hesitant to add the namespace to everything. If we add it to all the resources and don’t miss any then it would get you what you want. My concern is in the future a new resource gets added and it not having a namespace gets missed in PR. It wouldn’t really matter to those doing helm install/upgrade but for you, it would then cause the new resource to end up in the default namespace since it doesn’t have a namespace on it. @wongma7 what do you think about this?

Just out of curiosity what is your process in your pipeline that causes you to not want to use helm install/upgrade?

krmichel on Jun 23, 2021