release: Remove duplicates in `krel release-notes` output
What happened:
- Having headers in
krel release-notesoutput caused the end result of k/k changelog to have duplicated headers. We had to fix this in 1.20 and again in 1.21 after the release. - We also have duplicated
dependenciessection. In 1.21 we handled it in the same PR linked previously, while in 1.20 it was caught later on.
What you expected to happen:
Release notes team need not to manually edit document in k/sig-release before the release
How to reproduce it (as minimally and precisely as possible):
Create a minor release in k/k 😅
Anything else we need to know?:
/assign /cc pmmalinov01 puerco
Environment:
- Cloud provider or hardware configuration: -
- OS (e.g:
cat /etc/os-release): - - Kernel (e.g.
uname -a): - - Others: -
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 15 (11 by maintainers)
Amazing detective skillz! +1 for going with the first suggestion. In my mind, it falls in the idiomatic way of golang.
woah this is awesome investigation @jihoon-seo!
I think I like the first suggestion which we simply remove them, including the dependency / import diff because they’re also duplicated. the data in k/sig-release will be quite self-explanatory with which directory they’re located in.
in the scenario of people running
release-notestool (withoutkrel, different binary), they can change the output file name with the version 😄@puerco what do you think?
/priority backlog
heh
/ccdoesn’t work on issues, so manually now – cc: @pmmalinov01 @puerco