node-problem-detector: Unable to build code, missing godep

I cloned the repo and ran:

$ make node-problem-detector
CGO_ENABLED=0 GOOS=linux godep go build -a -installsuffix cgo -ldflags '-w' -o node-problem-detector
vendor/gopkg.in/fsnotify.v1/inotify.go:19:2: cannot find package "golang.org/x/sys/unix" in any of:
    /home/decarr/go/src/k8s.io/node-problem-detector/vendor/golang.org/x/sys/unix (vendor tree)
    /usr/local/go/src/golang.org/x/sys/unix (from $GOROOT)
    /home/decarr/go/src/k8s.io/node-problem-detector/Godeps/_workspace/src/golang.org/x/sys/unix (from $GOPATH)
    /home/decarr/go/src/golang.org/x/sys/unix
godep: go exit status 1
Makefile:9: recipe for target 'node-problem-detector' failed
make: *** [node-problem-detector] Error 1

Looks like this is missing a godep in master: https://github.com/kubernetes/node-problem-detector/tree/master/vendor

About this issue

Original URL
State: closed
Created 8 years ago
Comments: 25 (25 by maintainers)

Commits related to this issue

Merge pull request #7 from ringtail/bugfix/condition Bugfix/condition — committed to ringtail/node-problem-detector by ringtail 5 years ago

Most upvoted comments

Part of this is because github.com/hpcloud/tail vendors a a version of gopkg.in/fsnotify.v1 that doesn’t import golang.org/x/sys/unix. But godep flattens vendor folders and pulls up the dependency, so that there is only a single top level vendor directory. This required a version of gopkg.in/fsnotify.v1 be installed in the $GOPATH. The version vendored in hpcloud/tail is “7be54206639f256967dd82fa767397ba5f8f48f5” (1.2.1), while the version vendored in node-problem-detector is “30411dbcefb7a1da7e84f75530ad3abe4011b4f8”.

There is something else going on as well though.

freeformz on May 23, 2016