kubernetes: Should never allow vendored packages to reference k8s.io/kubernetes packages

vendor/k8s.io/heapster imports pkg/api/unversioned, which prevents refactors. Previously we imported rkt which imported pkg/resource, preventing a refactor.

We need a global import rule that any package that is vendored that references something in k8s.io/kubernetes needs to vendor or copy that dependency.

About this issue

  • Original URL
  • State: closed
  • Created 8 years ago
  • Comments: 30 (27 by maintainers)

Most upvoted comments

We can’t have it both ways… If we want people to import our packages, we have to make strong compat guarantees. If we want to dodge strong compat guarantees, we can’t allow people to import…

On Mon, Nov 28, 2016 at 5:02 PM, Clayton Coleman notifications@github.com wrote:

Please don’t do that, you’ll break openshift horribly.

On Nov 28, 2016, at 7:25 PM, Tim Hockin notifications@github.com wrote:

Or we should do more to unexport packages that we don’t want people outside of our repo to use in the first place.

On Mon, Nov 28, 2016 at 7:11 AM, Wojciech Tyczynski < notifications@github.com> wrote:

@piosz https://github.com/piosz - FYI

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/kubernetes/kubernetes/issues/37556# issuecomment-263295576 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AFVgVFYdsYTST-Fckg_ Un9j2gO2T0CmSks5rCu8VgaJpZM4K94lQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/kubernetes/kubernetes/issues/ 37556#issuecomment-263438628>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG_px_KHoXtrc- 7SgOLMAIgKypwd0Ivks5rC3D1gaJpZM4K94lQ> .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kubernetes/kubernetes/issues/37556#issuecomment-263444893, or mute the thread https://github.com/notifications/unsubscribe-auth/AFVgVOAmVAgFVWf0jyS9KVCzuzBtsI3Eks5rC3mogaJpZM4K94lQ .