kubernetes: Replace "success/failure" nouns with the actual pod adjective phases (succeeded or failed).
What would you like to be added:
The E2E tests evaluate Pod Phases adjectives, describing the state of a pod, i.e. Succeeded, Failed, and so on. But, they log nouns (success or failure).
Waiting up to 5m0s for pod "client-can-connect-80-5x9dw" in namespace "network-policy-8096" to be "success or failure"
Why is this needed:
Right now when reading tests, it takes a tiny leap of faith to correlate “success or failure” with the pod phase “failure”, and one wonders wether ‘failed’ literally means the pod phase is Failed. Making the condition match the exact semantics of this pod phase makes test logs consistent from a readability perspective.
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Comments: 17 (6 by maintainers)
oh i already did this also… https://github.com/kubernetes/kubernetes/pull/87576 but the other pr looks fine as well. whatever 😊
@sureshpalemoni I was already working on it, do you want to share any ideas?