kubernetes: Prevent `Comment` field conflicts in Godeps/Godeps.json
What would you like to be added:
Prevent Comment field conflicts in Godeps/Godeps.json
Why is this needed:
godep may generate different comments on same commit in same repo. It’s annoying when updating dependencies. More discussion: https://github.com/kubernetes/kubernetes/pull/69976#pullrequestreview-167565874
godep uses git describe --tags <commit> to generate comment, different git versions or local configs will generate different results (latest git use dynamic abbreviation size by default which depends on repo state). And some repo may tag one commit with multiple names which results in multiple comments (depends on your repo state), e.g.
- https://github.com/go-openapi/analysis/tree/v0.17.1
- https://github.com/go-openapi/analysis/tree/v0.17.2
/kind feature
About this issue
- Original URL
- State: closed
- Created 6 years ago
- Comments: 19 (19 by maintainers)
There’s a small group of individuals in our community who sign up for the dirtiest jobs, over and over. I love you guys.
pokes head up
I may or may not have a branch burning a hole on my compy to do just that. The problem with messing with git configs is you don’t just have to do it for k/k, but you have to do it for every repo that godep restores and clones down (yuck)
Let me clean up my branch and see how far that gets us.
https://github.com/kubernetes/kubernetes/pull/70718 /shrug