kubernetes: Many CNI Plugins don't properly support DEL

Started as a tangent of #43014

Many CNI plugins don’t properly handle a DEL action on missing resources. The spec says, Plugins should generally complete a DEL action without error even if some resources are missing, however many improperly return an error.

I see the steps moving forward to be:

  • Modify CNI plugins bundled with Kubernetes to properly support del (flannel already done; bridge, ipvlan, macvlan, and ptp in containernetworking/cni#412)
  • Create release of containernetworking/cni
  • Build Kubernetes version of CNI using Makefile
  • Modify references to CNI version throughout project

Does this make sense?

cc/ @caseydavenport @luxas @calebamiles @yujuhong @janwillies @yujuhong @dchen1107 @djosborne @jbeda @bowei @thockin @feiskyer @aaronlevy @sameo @GheRivero @tomdee @bboreham @cmluciano @dcbw @freehan

About this issue

  • Original URL
  • State: closed
  • Created 7 years ago
  • Comments: 17 (13 by maintainers)

Commits related to this issue

Most upvoted comments

@cmluciano It would be great to get flannel tested too. You probably need a master build of the flannel CNI plugin and possibly some flannel patches to be merged. Feel free to DM on slack if you need more info.

I just want to say thanks to everyone for jumping on this.

On Tue, Mar 21, 2017 at 6:11 PM, Tom Denham notifications@github.com wrote:

SGTM - I’m working on the containernetworking/cni#412 https://github.com/containernetworking/cni/pull/412 right now and can do the CNI release too.

On the 3rd check box Build Kubernetes version of CNI using Makefile - why is that still a thing? Doesn’t the CNI project provide the required artifacts as part of its release?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kubernetes/kubernetes/issues/43488#issuecomment-288268141, or mute the thread https://github.com/notifications/unsubscribe-auth/AFVgVGkFp5TdvpmjE3qMsW3A8pxwxhEOks5roHU3gaJpZM4MkmnC .