kubernetes: build/rpms fails without rpmbuild installed, causing `make bazel-build` to fail
Is this a BUG REPORT or FEATURE REQUEST?: /kind bug
What happened: make bazel-build can fail with confusing errors caused by build/rpms (see: https://github.com/kubernetes/test-infra/issues/5429)
What you expected to happen: These targets should either be manual only or be hermetic. Additionally, these are not being run in CI because nothing depends on them. If they are not made manual then the CI needs to be updated to include them and needs to install rpmbuild.
How to reproduce it (as minimally and precisely as possible): run make bazel-build against kubernetes master from a linux box without rpmbuild in $PATH.
Anything else we need to know?:
Environment:
- ref:
899f7ff97d5fa5f16831b3e09c6cb9ccfdf73479 - Bazel 0.7.0
- Linux, without
rpmbuild
About this issue
- Original URL
- State: closed
- Created 7 years ago
- Reactions: 1
- Comments: 15 (14 by maintainers)
We need a target that builds everything.
My personal approach would be to require rpmbuild only for
make bazel-releaseand leavemake bazel-buildproduce just binaries.I’m fine adding these tools to our bazelbuild image for now, but we should file an issue against upstream bazel because this is not a workable long-term solution.