kubeadm: Slow running unit tests

@fabriziopandini has reported some slow running unit tests:

//cmd/kubeadm/app/cmd/phases:go_default_test                             PASSED in 44.8s
//cmd/kubeadm/app/discovery/token:go_default_test                        PASSED in 19.3s
//cmd/kubeadm/app/phases/certs:go_default_test                           PASSED in 34.1s
//cmd/kubeadm/app/phases/certs/pkiutil:go_default_test                   PASSED in 7.1s
//cmd/kubeadm/app/phases/controlplane:go_default_test                    PASSED in 5.4s
//cmd/kubeadm/app/phases/kubeconfig:go_default_test                      PASSED in 12.9s
//cmd/kubeadm/app/phases/markmaster:go_default_test                      PASSED in 3.7s
//cmd/kubeadm/app/phases/upgrade:go_default_test                         PASSED in 18.2s

in my case tests run significantly faster - e.g. cmd/kubeadm/app/cmd/phase takes around ~20 seconds. but we are logging this issue in case this can be improved.

for instance i did some investigation in here: https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/cmd/phases/certs_test.go#L105 (which is one of the longest running tests).

i don’t see anything wrong with the code, which to me means that the code simply does a lot of operations (too many files + sub-commands?). we could either remove the amount of tests or leave it as is for now.

About this issue

Original URL
State: closed
Created 6 years ago
Comments: 18 (17 by maintainers)

Commits related to this issue

kubeadm: run app/cmd/phases tests in parallel Issue kubernetes/kubeadm#952 mentions ppp/cmd/phases tests as the slowest among kubeadm tests. Running tests in parallel shows substantional speedup: -... — committed to bart0sh/kubernetes by bart0sh 6 years ago

Most upvoted comments

I can’t repro the flakes. Running with --runs_per_test 10 produces no failures.

My slowest tests were:

//cmd/kubeadm/test/cmd:go_default_test                                   PASSED in 46.8s
  Stats over 10 runs: max = 46.8s, min = 39.6s, avg = 44.0s, dev = 2.1s
//cmd/kubeadm/app/phases/certs:go_default_test                           PASSED in 39.2s
  Stats over 10 runs: max = 39.2s, min = 32.5s, avg = 36.4s, dev = 2.2s
//cmd/kubeadm/app/phases/upgrade:go_default_test                         PASSED in 27.4s
  Stats over 10 runs: max = 27.4s, min = 23.6s, avg = 24.8s, dev = 1.2s
//cmd/kubeadm/app/cmd/phases/certs:go_default_test                       PASSED in 18.0s
  Stats over 10 runs: max = 18.0s, min = 12.8s, avg = 15.9s, dev = 1.6s

liztio on Oct 30, 2018