kube-state-metrics: kube-state-metrics should not use CreatedByAnnotation
Based on this announcement, CreatedByAnnotation will be deprecated in 1.8 in favor of ControllerRef. However, the annotation is still used in this repo here.
As CreatedByAnnotation will be deprecated, we may have to remove this gauge or set it to <none>. I wish to ask for feedback regarding removal of the gauge.
About this issue
- Original URL
- State: closed
- Created 7 years ago
- Comments: 21 (14 by maintainers)
As Kubernetes 1.9.0 has finally removed the support for
CreatedByAnnotationand we have update client-go to v6.0.0 in #328 which does not supportCreatedByAnnotationany more, kube-state-metrics does not useCreatedByAnnotationannotation any more. So, closing this. 😃Yes, let’s keep it open, until we actually remove them. Thanks for your efforts @crimsonfaith91 !
As we already fully support everything the owner reference gives us in terms of information I don’t see anything we need to do here. The
created_by_kindandcreated_by_namelabels can continue to exist but will simply be filled with<none>values, this doesn’t do any harm. We can explicitly deprecate them and remove them in a future release.@crimsonfaith91 yep that’s how I understood everything as well.