pipelines: [backend] missing 'v' prefix in repo tags

When trying to use the go client in github.com/kubeflow/pipelines/backend/api/go_client, I find that go mod can’t fetch the corresponding tags in this github repo, because all tags defined are missing the ‘v’ prefix and are considered non-canonical tag formats.

E.g., tag ‘1.5.1’ should be ‘v1.5.1’.

About this issue

Original URL
State: open
Created 3 years ago
Reactions: 2
Comments: 16 (15 by maintainers)

Commits related to this issue

Revert "feat: change release tags to vX.Y.Z. Fixes #5954 (#5974)" This reverts commit b57bbeeb982744556ab79a132de5d5fd0c7c0c82. — committed to kubeflow/pipelines by Bobgy 3 years ago
revert: feat: change release tags to vX.Y.Z. Part of #5954 (#6034) This reverts commit b57bbeeb982744556ab79a132de5d5fd0c7c0c82. — committed to kubeflow/pipelines by Bobgy 3 years ago

Most upvoted comments

Also found that python package version should not have the ‘v’ prefix either: https://www.python.org/dev/peps/pep-0440/.

I feel that we should only add the ‘v’ prefix on git tags, but avoid it in other cases. It might take quite some trial and error to figure out which versions require the v prefix and which don’t.

@NikeNano I’m leaning towards reverting the PR and revisit it in the next release to delay resolving the problems we’ve seen. What do you think?

Bobgy on Jul 14, 2021

Added to release tracker

Bobgy on Jul 2, 2021

Yep, probably also

TODOs:

the release docs TAG=v1.4.0 BRANCH=release-1.4 make release
In some build scripts, we parse tag version
update cloud build trigger pattern (only admins can udpate)

Bobgy on Jul 13, 2021