ksh: Regression test failure @32950afe w/ macOS 12.7.3 (Intel or ARM)
The io regression tests have errors. Reverting the referenced commit removes the errors.
test io begins at 2024-02-09+05:49:50
io.sh[240]: FAIL: <# not working for pipes
io.sh[344]: FAIL: read -n3 from pipe not working
io.sh[353]: FAIL: read -n3 from fifo failed -- expected 'a', got 'abc'
io.sh[356]: FAIL: read -n1 from fifo failed -- expected 'b', got 'd'
io.sh[386]: FAIL: should have timed out
io.sh[387]: FAIL: line1 should be 'prompt1: '
io.sh[388]: FAIL: line2 should be line2
io.sh[389]: FAIL: line3 should be 'prompt2: '
io.sh[413]: FAIL: LC_ALL=C read -n2 from pipe 'a bcd' failed -- expected 'a bcd', got 'ab cd'
io.sh[413]: FAIL: LC_ALL=C.UTF-8 read -n2 from pipe 'a bcd' failed -- expected 'a bcd', got 'ab cd'
test io failed at 2024-02-09+05:49:53 with exit code 10 [ 166 tests 10 errors ]
test io(C.UTF-8) begins at 2024-02-09+05:49:53
io.sh[240]: FAIL: <# not working for pipes
io.sh[344]: FAIL: read -n3 from pipe not working
io.sh[353]: FAIL: read -n3 from fifo failed -- expected 'a', got 'abc'
io.sh[356]: FAIL: read -n1 from fifo failed -- expected 'b', got 'd'
io.sh[386]: FAIL: should have timed out
io.sh[387]: FAIL: line1 should be 'prompt1: '
io.sh[388]: FAIL: line2 should be line2
io.sh[389]: FAIL: line3 should be 'prompt2: '
io.sh[413]: FAIL: LC_ALL=C read -n2 from pipe 'a bcd' failed -- expected 'a bcd', got 'ab cd'
io.sh[413]: FAIL: LC_ALL=C.UTF-8 read -n2 from pipe 'a bcd' failed -- expected 'a bcd', got 'ab cd'
test io(C.UTF-8) failed at 2024-02-09+05:49:55 with exit code 10 [ 166 tests 10 errors ]
test io(shcomp) begins at 2024-02-09+05:49:55
shcomp-io.ksh[240]: FAIL: <# not working for pipes
shcomp-io.ksh[344]: FAIL: read -n3 from pipe not working
shcomp-io.ksh[353]: FAIL: read -n3 from fifo failed -- expected 'a', got 'abc'
shcomp-io.ksh[356]: FAIL: read -n1 from fifo failed -- expected 'b', got 'd'
shcomp-io.ksh[386]: FAIL: should have timed out
shcomp-io.ksh[387]: FAIL: line1 should be 'prompt1: '
shcomp-io.ksh[388]: FAIL: line2 should be line2
shcomp-io.ksh[389]: FAIL: line3 should be 'prompt2: '
shcomp-io.ksh[413]: FAIL: LC_ALL=C read -n2 from pipe 'a bcd' failed -- expected 'a bcd', got 'ab cd'
shcomp-io.ksh[413]: FAIL: LC_ALL=C.UTF-8 read -n2 from pipe 'a bcd' failed -- expected 'a bcd', got 'ab cd'
test io(shcomp) failed at 2024-02-09+05:49:58 with exit code 10 [ 166 tests 10 errors ]
About this issue
- Original URL
- State: closed
- Created 5 months ago
- Comments: 16
Commits related to this issue
- Fix 'read' regressions (re: 1a3e247e) As of the referenced commit, ksh93's pipe_socketpair feature test from features/poll fails to compile, because _ast_signal() is not declared. This in turn causes... — committed to ksh93/ksh by McDutchie 5 months ago
- Fix 'read' regressions (re: 32950afe) As of the referenced commit, ksh93's pipe_socketpair feature test from features/poll fails to compile, because _ast_signal() is not declared. This in turn causes... — committed to JohnoKing/ksh by McDutchie 5 months ago
So, the fix may be as simple as including AST
<sig.h>instead of<signal.h>in that feature test, as the latter is included by the former and also includes the necessary extern for the rename mapping.Works for me on macOS 12.7.3.