react-starter-kit: Hot module reloading doesn't work

I have cloned latest master which is 048e67f, did npm install && npm start, and hot reloading doesn’t work.

The browser window was opened with localhost:3001, and changes saved in my editor does trigger recompiling and the changes can be seen when refreshing, but there’s no hot module replacement (or even auto refreshing) happening.

About this issue

Original URL
State: closed
Created 8 years ago
Comments: 16 (5 by maintainers)

Commits related to this issue

Improve Hot Updates - Add support for hot update of [`PureComponent`](https://facebook.github.io/react/docs/react-api.html#react.purecomponent) and components with [`shouldComponentUpdate`](https://f... — committed to frenzzy/react-starter-kit by frenzzy 8 years ago
Improve Hot Updates (#938) Improve Hot Updates - Add support for hot update of [`PureComponent`](https://facebook.github.io/react/docs/react-api.html#react.purecomponent) and components with [`sho... — committed to kriasoft/react-starter-kit by frenzzy 8 years ago

Most upvoted comments

@socrat3z @frenzzy For me HMR started working on react-intl branch, when I changed this part of client.js to

// Enable Hot Module Replacement (HMR)
if (module.hot) {
  module.hot.accept('./router', () => {
    if (appInstance && appInstance.updater.isMounted(appInstance)) {
      // Force-update the whole tree, including components that refuse to update
      deepForceUpdate(appInstance);
    }
+    onLocationChange(currentLocation); // <<<< added onLocationChange() here, it was removed previously
  });
}

maksimkurb on Feb 5, 2018

Do you see pending request on devtools network tab after hot changes?

frenzzy on Oct 24, 2016