eventing: [Experimental] Spec non-compliance: `spec.subscriber` MUST be set

Describe the bug As part of https://github.com/knative/specs/pull/30 to simplify the user experience of Subscriptions, the spec was changed from requiring one of spec.subscriber or spec.reply to be set to requiring that spec.subscriber is set.

Expected behavior An admission validation error if a Subscription is created without a subscriber.

To Reproduce Create a Subscription like so:

apiVersion: messaging.knative.dev/v1
kind: Subscription
metadata:
  name: i-am-a-bad-bad-subscription
spec:
  channel:
    kind: Channel
    apiVersion: messaging.knative.dev/v1
    name: dont-care
  reply:
    uri: http://dev/null

Knative release version

0.26

Additional context Should probably get this in for 1.0

About this issue

  • Original URL
  • State: closed
  • Created 3 years ago
  • Comments: 16 (15 by maintainers)

Commits related to this issue

Most upvoted comments

@lionelvillard ok so to promote this to beta, we need to enable the flag by default, which can make some tests fail as mentioned by @aliok

I can send a PR for that, so this feature will be beta in 1.3 and we can make it final in 1.4