license-report: Fails with versions like "nightly" and "latest"
license-report
just tells me skipping package@nightly (invalid semversion)
for any version that isn’t parsable as a semver.
But why does it need the version anyway?
npm accepts these “versions”, so it seems like license-report
should as well.
Thank you!
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 21
Commits related to this issue
- Merge pull request for issue #51 from 'pu/nightly' feat: Accept versions like "nightly" and "latest" — committed to kessler/license-report by BePo65 3 years ago
Fixed in next release based on pr #65.
looks like we should promote you to head of project QA 😉
But seriously: that’s definitely a bug, so please create an issue for this and I will fix it - it is just a small code change.
@folknor I just uploaded a branch named
pu/nightly
. This adds a new fielddefinedVersion
to the fields of license-report that contains the version as defined in the package.json file. Besides this new field, this branch will handle prerelease- (e.g.1.0.0-alpha.1
) and dist-tags (e.g.nightly
). I would appreciate it, if you could use this branch for a real world test and give me some feedback.Thanks for the fast response; I’ll prepare a PR