delft: max_sequence_length not used(?)

Hi @kermitt2

I was just considering whether we need sliding windows to not have to use a really large max_sequence_length. But then I realised that max_sequence_length doesn’t actually seem to be used. It’s passed to the DataGenerator which doesn’t seem to use it. Instead it simply pads the batch to whatever the maximum length is within the batch.

About this issue

  • Original URL
  • State: closed
  • Created 5 years ago
  • Comments: 32 (21 by maintainers)

Most upvoted comments

Yes, I just had this problem, if the sequences are truncated in the tagging, then grobid will crash with IndexOutOfBounds. The fix is in #97 .