tera: (Rant) 1.14.0 changes signature of `Context`, breaks grcov
Hello,
Tera 1.14.0 adds a generic parameter to Context, which breaks anyone who mentioned this type in their code. One such program is grcov, which is used by many to calculate test coverage. I see the warning in the README, but isn’t Context public?
I already submitted a PR to fix grcov, and I don’t expect you to do anything about this. Just please, be more considering the next time you change a public type 😉
Thanks!
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Reactions: 4
- Comments: 19 (7 by maintainers)
sorry again 😦 For what it’s worth this is probably the last release for a long time so it shouldn’t happen again. I’ll be more careful in the future, the last 2 releases have been messy
I’ve just yanked it and will publish a 1.15 with the non breaking changes from 1.13, sorry again about that.
I’ll add context level functions to the feature list of v2 and will probably not release the current code as I don’t want a v2 to just be a small feature like that.
Ah shit I forgot about that 😦 The new version was needed because 1.13 made
Contextnot sync+send by accident and that was a way to fix it.Are you holding the context in a struct somewhere? Most use cases of
Contextshould not change?@Keats
No, grcov was simply unlucky to mention the type at all: https://github.com/mozilla/grcov/pull/697/files#diff-4670146df578274a2be5b97fc67deab17145720f0deeada6fc8d2fa50901d65fL211 Easily fixed, as you can see.
For anyone coming to this issue because of grcov: you can fix you CI by forcing Cargo to use Cargo.lock by running
cargo install --locked grcov.