samsungctl: Wrong path handling for config file saving

I tried the latest version and, as described, the functionality to save a config file with the values for my TV. If I use the config-file path ~/Desktop/config.cfg the config file ends up in a subdirectory ~/Desktop below the directory I am calling samsungctl from.

About this issue

  • Original URL
  • State: closed
  • Created 5 years ago
  • Comments: 28 (17 by maintainers)

Most upvoted comments

as you probably already know. I did take a look at that HomeBridge thing.

This is what I found at a quick glance of the code.

  • only supporting 2016+ TV’s with new firmware only it looks like.
  • aren’t using the application support to it’s fullest.
  • do not have all of the key codes.
  • require a manual mac address entry.
  • I believe they are they are creating a websocket connection over and over again for each command that is sent. I could be wrong on that tho.
  • using a sleep timer of 500 milliseconds is not a long enough delay for an application list. and that is what they are using. I have logs for app lists taking 2-3 seconds to be returned by the TV.
  • the use of sleep timers to wait for data not a good mechanism
  • sending a ping packet to test for connectivity
  • I didn’t notice a thread loop for receiving data (this is the mechanism you would use to check connectivity)
  • no support for activating the voice recognition.
  • no mouse support
  • no text entry support
  • no UPNP support
  • not using 8001/api/v2 to determine connection type