ruby-jwt: 1.5.3 breaks compatibility with 1.5.2
hey folks,
the API breaks between 1.5.2 and 1.5.3. For example, ::JWT.decoded_segments(token) no longer exists.
would you mind, going forward, if the API changes, to increment at least a minor, if not major, revision number?
thanks!
About this issue
- Original URL
- State: closed
- Created 8 years ago
- Comments: 17 (9 by maintainers)
Thanks a lot for all the feedback. Lessons learned from the 1.5.3 disaster.
Version 1.5.3 yanked.
Thanks @excpt - unless you make it private methods, undoubtedly someone will find it and use it. Actually, probably for private methods too. But its been used apparently over a thousand times and these are just public repos.
ah, yep, I ran into this as well. 6 projects started to fail.
Would you mind putting 1.5.3 back up? Once it is published it should be locked. If you wouldn’t mind, just publish 1.5.4 with backwards compatibility, and just going forward stick to semantic versioning? But the key is going forward 😃 @excpt, if I can help (besides calling shots from the cheap seats!) please let me know.
I would suggest publishing 1.5.4 with a fork of the 1.5.2 code (only changes would be version and readme / changelog)
On 24 March 2016 at 15:01, Alex Schultz notifications@github.com wrote:
Please don’t yank things until you’ve published something newer. You’ve broken a whole bunch of CIs as 1.5.3 is being calculated as a dependency but is not available.