github-wc-polyfill: Argh... GitLab is broken again (regex/named capture groups)
Today must be a horrible day for everybody using source hosting sites which are hellbent on making life miserable to anyone not using Chrome®™ or a Chrome®™-compatible browser. Now GitLab is breaking again because they decided it was a good idea to deploy named capture groups on their regexes for no good reason at all.
Apparently the polyfills injected by the addon cause GitLab to load one of their scripts… which breaks because it now contains unsupported regexes. The error console logs this:
SyntaxError: invalid regexp group commons-pages.admin.topics.edit-pages.admin.topics.new-pages.groups.epics.new-pages.groups.epics.sho-59a8e774.9fc6fd37.chunk.js:1:285
onStopRequest jar:file:///home/tomman/.mozilla/seamonkey/7b88ug1a.default/extensions/github-wc-polyfill@Off.JustOff.xpi!/bootstrap.js:430:7
Since SeaMonkey doesn’t support named capture groups (yet), the entire tower of cards falls down there, and GitLab goes back to its usual behavior for anyone not using A Blessed Browser™ (i.e. everything broken, can’t read anything but the first post on a issue, etc.)
When will the madness stop!? Maybe it’s time to declare JavaScript and Google war criminals against mankind at the United Nations 😕
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Reactions: 2
- Comments: 46 (3 by maintainers)
Commits related to this issue
- Revert regular expression workaround of emoji d147dbb Instances may not be updated: https://github.com/JustOff/github-wc-polyfill/issues/45#issuecomment-1066105393 — committed to JustOff/github-wc-polyfill by SeaHOH 2 years ago
- Bypass "invalid regexp group" error on GitLab https://github.com/JustOff/github-wc-polyfill/issues/45#issuecomment-1069796890 — committed to JustOff/github-wc-polyfill by SeaHOH 2 years ago
- Bypass "invalid regexp group" error on GitLab https://github.com/JustOff/github-wc-polyfill/issues/45#issuecomment-1087765302 — committed to JustOff/github-wc-polyfill by SeaHOH 2 years ago
github-wc-polyfill-1.2.17b2
Here is a dirty error bypass hack: 1.2.13b3.
github-wc-polyfill-1.2.18.2.xpi This release includes all the patches for “invalid regexp group”.
Once again, thank you very much, @JustOff !!!
Another small victory in this endless cat-and-very-shiny-mouse chase. Can confirm that Gitlab works again on SeaMonkey.
Ironically, when you open the console there, you get a welcoming message to “make GitLab more lovable” (complete with emojis, ON A CONSOLE). Sure, right, “lovable”. As long as you love Chrome®™, of course!
What the good students are they?
github-wc-polyfill-1.2.18b1.xpi
https://gitlab.com/gitlab-org/gitlab/-/commit/775a98516a5c4f35d7320ed1be2dc442937e367b
github-wc-polyfill-1.2.17b1 The main GL was droped escape emoji in regular expression, but some instances may not be.
Yep, it in the plan, but isn’t pressing.
please increase the version number in
update.xml(1.2.18.1 and 29)It will be commited later. And now, view it in xpi package.
It’s Debian, what do you expect :^)
indeed, it would be much nicer to detect that it needs the old fix by checksumming (or checking filesize) of the js script in question.
btw it seems salsa.debian.org also uses an older version of gitlab.
it happens again:
which is:
l=/^(?<indent>\s*)(?<leader>((?<isUl>[*+-])|(?<isOl>\d+\.))( \[([xX ])\])?\s)(?<content>.)?/,c=/^((\s{0,3}-+\s*-+\s*-+\s*[\s-]*)|(\s{0,3}\*+\s*\*+\s*\*+\s*[\s*]*))$/;@SlySven Please comment to the corresponding issue. #59
on ST52 + 1.2.17 I don’t know if it matters, but on the given page I have it
https://gitlab.freedesktop.org/mesa/mesa/-/issues/6145ok 1.2.16 bad 1.2.17https://gitlab.com/seamonkey-project/seamonkey-2.53-mozilla/-/commit/1a9bb8dcae068ea13ddbabcb5620f4e5ab0ea1f8bad 1.2.16 ok 1.2.17😕
@l29ah The site app is outdated, you should ask the manager to update, or use old add-on.
This is better.
😡 ; “main” GitLab is again BROKEN here (202203170045 UTC), due to them using unsupported (in UXP) regex syntax… 👎 😠
Latest St52+
gh-wc-pf-1.2.16/1.2.17b1, sample GL URL: https://gitlab.com/seamonkey-project/seamonkey-2.53-mozilla/-/commit/1a9bb8dcae068ea13ddbabcb5620f4e5ab0ea1f8 Result:Error Console log:
… Seems there’s no end to this ordeal 😭 ; one day is GH, the next GL, and so on… 😞
on ST52
in https://foss.heptapod.net/seamonkey/mozilla-release it shows this error:
I restart my browser, and it work. May caused by my network.
I checked some GitLab addresses and it works fine on ST52
An example URL. plz.