notebook: Uploading large files crashes the browser
If you try to upload a file that is larger than ~35mb the browser tab will crash about 5 seconds after clicking “Upload”.
If we could warn the user about large files or implement a file uploader the user expirience would be better.
# python -c "import IPython; print(IPython.sys_info())"
{'commit_hash': u'fd4ede2',
'commit_source': 'installation',
'default_encoding': 'UTF-8',
'ipython_path': '/usr/local/lib/python2.7/dist-packages/IPython',
'ipython_version': '4.0.0-dev',
'os_name': 'posix',
'platform': 'Linux-3.13.0-49-generic-x86_64-with-Ubuntu-14.04-trusty',
'sys_executable': '/usr/bin/python',
'sys_platform': 'linux2',
'sys_version': '2.7.6 (default, Mar 22 2014, 22:59:56) \n[GCC 4.8.2]'}
About this issue
- Original URL
- State: closed
- Created 9 years ago
- Comments: 27 (16 by maintainers)
Commits related to this issue
- Merge pull request #2162 from blackrock/master Fix for uploading large files crashing the browser (issue #96) — committed to jupyter/notebook by rgbkrk 7 years ago
The PR for this (#2162) was actually merged for 5.0, despite what we said here.
@Carreau @blink1073 I have finished the code and testing, etc. Right now I’m waiting on our company (BlackRock)'s legal/compliance team to give an approval for pull request. We will be contributing through BlackRock-engineering account https://github.com/blackrock.
This is my first time making pull request. Just to understand the process, does the following sound right:
We have solved the problem of loading large files by chunking. We also added a progress bar to indicate the upload progress. In our experiment we tried files with a few Gs with no problem.
I would be happy to contribute the code. Please let me know what’s the process. Thank you!