eslint-plugin-react: `destructuring-assignment` shouldn't trigger on method calls

The rule react/destructuring-assignment is also triggered when using methods of params.

      formatter: (val) => {
        return <span>{val.toPrecision(2)}</span>;
      },

Might also be related to #1950

About this issue

Original URL
State: closed
Created 3 years ago
Reactions: 2
Comments: 16 (13 by maintainers)

Commits related to this issue

Disable broken lint This lint is not functioning properly. See: https://github.com/yannickcr/eslint-plugin-react/issues/2960 Signed-off-by: Darian Plumb <dplumb@bitwise.io> — committed to dplumb94/splinter-ui by dplumb94 3 years ago
Downgrade eslint-plugin-react due to broken lint This lint is not functioning properly in 7.23. See: https://github.com/yannickcr/eslint-plugin-react/issues/2960 Signed-off-by: Darian Plumb <dplumb@... — committed to dplumb94/splinter-ui by dplumb94 3 years ago
Downgrade eslint-plugin-react due to broken lint This lint is not functioning properly in 7.23. See: https://github.com/yannickcr/eslint-plugin-react/issues/2960 Signed-off-by: Darian Plumb <dplumb@... — committed to dplumb94/splinter-ui by dplumb94 3 years ago
Pin eslint dependency This pins eslint due to bug: https://github.com/yannickcr/eslint-plugin-react/issues/2960 Signed-off-by: Davey Newhall <newhall@bitwise.io> — committed to dnewh/splinter-ui by dnewh 3 years ago
Pin eslint dependency This pins eslint due to bug: https://github.com/yannickcr/eslint-plugin-react/issues/2960 Signed-off-by: Davey Newhall <newhall@bitwise.io> — committed to dnewh/splinter-ui by dnewh 3 years ago
Pin eslint dependency This pins eslint due to bug: https://github.com/yannickcr/eslint-plugin-react/issues/2960 Signed-off-by: Davey Newhall <newhall@bitwise.io> — committed to dnewh/splinter-ui by dnewh 3 years ago
Pin eslint dependency This pins eslint due to bug: https://github.com/yannickcr/eslint-plugin-react/issues/2960 Signed-off-by: Davey Newhall <newhall@bitwise.io> — committed to dnewh/splinter-ui by dnewh 3 years ago
[Fix] component detection: use `estraverse` to improve component detection Fixes #2960. — committed to Wesitos/eslint-plugin-react by Wesitos 3 years ago
Downgrade eslint-plugin-react due to broken lint This lint is not functioning properly in 7.23. See: https://github.com/yannickcr/eslint-plugin-react/issues/2960 Signed-off-by: Darian Plumb <dplumb@... — committed to ameliabradley/grid by dplumb94 3 years ago
Downgrade eslint-plugin-react due to broken lint This lint is not functioning properly in 7.23. See: https://github.com/yannickcr/eslint-plugin-react/issues/2960 Signed-off-by: Darian Plumb <dplumb@... — committed to ameliabradley/grid by dplumb94 3 years ago

Most upvoted comments

No, since those could still be performing side effects.

Sounds like a hook 😛

Component detection is always a WIP and could always use improvements; PRs are welcome.

I’ll give it a check. Thanks

Wesitos on May 22, 2021

Even with formatter(val) { it’s still detecting it as a component.

rohit-gohri on Apr 4, 2021