jsperf.com: Cannot edit own test

It doesn’t seem possible to edit my own tests as it just creates a new page instead of updating as request.yar.get('own') never gets set. It might just be something with my setup.

About this issue

  • Original URL
  • State: closed
  • Created 8 years ago
  • Comments: 17 (14 by maintainers)

Commits related to this issue

Most upvoted comments

The email field was there because we use it to display avatars (through Gravatar). If we already get access to the email address through GitHub OAuth then I agree we don’t need the field anymore — we can store it implicitly. 👍

You did not understand the question. When an open source project is considered abandoned the original author(s) have lost interest in it. Basically drops the ball and walks away.

In case you havn’t noticed is this an open-source project. People don’t get paid. People do this because they think it’s fun. Pay people to fix it, wait, or fix it yourself.

What’s with that condescending attitude? Such a waste of time. So unnecessary and uncalled for. Learn to control your damage and keep it to yourself. Talk to a friend or a professional or both, please. There are even forums for it. This site is however not the place.

I just made a very quick dirty fix for that at https://github.com/LeZuse/jsperf.com/pull/1

“I do not understand why this is so hard to fix.” is what’s up.

A PR is worth more than a thousand pings.

I do not understand why this is so hard to fix. It worked before. Why not use the git repo history to track down what changes broke the site?

The project has been rewritten from scratch in Node.js. The old version was PHP-based. There is no change that broke this — it just hasn’t been implemented yet in the new version. If you had taken your own advice and “used the git repo history” you would’ve known this already.

“I do not understand why this is so hard to fix.” is what’s up.

No, this project is not abandoned. In case you havn’t noticed is this an open-source project. People don’t get paid. People do this because they think it’s fun. Pay people to fix it, wait, or fix it yourself.

correct, we would need to alter the mysql schema to store something unique from their profile

how can we avoid people tampering with the data in the callback from Github?

OAuth is trustworthy enough for me