resume-schema: Research for #331
Should work.name be reverted back to work.company?
This was an undocumented breaking change introduced in #270 that had the unfortunate impact of breaking a LOT of existing JSONResume template projects. This issues exists to search for, and discover how big that impact was and whether the change should be reverted.
If it is reverted, the change will be re-introduced in the planned v1.0 release so users who require the change can bump major to use it.
Template
- jsonresume-theme-material - work.company
- jsonresume-theme-macchiato - work.name
- jsonresume-theme-randytarampi - work.company
- jsonresume-theme-orbit-original - work.name
- jsonresume-theme-eloquent-ru - work.company
- jsonresume-theme-orbit - work.name
- gatsby-theme-jsonresume - work.company
- jsonresume-theme-moon - work.company
- jsonresume-theme-stackoverflow2 - work.name
- jsonresume-theme-elegant - work.company
- jsonresume-theme-even - work.name
- jsonresume-theme-samk - work.company
- kcv-theme-print-flexbox - work.company
- jsonresume-theme-standard-resume - work.company
- jsonresume-theme-apage - work.company
- kcv-theme-rocketspacer - work.company
- jsonresume-theme-standard-resume-de - resume.company
- jsonresume-theme-elegant-jali - work.company
- kcv-theme-simple-red - work.name
- @tjscollins/jsonresume-theme-streamline - work.company
- jsonresume-theme-macchiato-ibic - work.name
- jsonresume-theme-nl-flat - work.company
- jsonresume-theme-pumpkin - work.company
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Comments: 15 (11 by maintainers)
I’ve created an issue to notify themes that are incompatible with this change. We can close this issue now.
After reading this issue more closely, I’ve interpreted it as follows: we introduced a breaking change (going from
work.companytowork.name, and the proposal is to revert this change and reintroduce it for 1.0.0. Given that we’re now making a last push to 1.0.0, it seems silly to revert the change because we would be bringing it back very shortly.Another point to consider, is that quite some themes have moved to
work.namealready and it’s not at all clear that the majority is still onwork.company.And lastly, given that we’re not at 1.0.0 yet, breaking changes are to be expected, so let’s not confuse the community even more by reverting back and forth.
So conclusion (as far as I’m concerned):
work.nameis the way to go, which is already in the schema, so let’s keep it like that and change this issue to track which themes need to change and help them by creating issues/PRs on their repos. Agree?@evanplaice Yeah I woke up this morning and I’ve changed my mind. Maybe, let’s not do breaking changes.
I think such bot could come in handy in the long run then exactly for the reason to inform theme creators to support new changes to the spec like
projects. Who knows, if its sophisticated enough it might even suggest a PR with the changes (ML ftw haha).Maybe I should spend time building a bot that finds all
jsonresume-theme-*repos and it creates an issue for the new breaking change.I think we can manage a bit of turmoil for a proper release e.g. v1