json-editor: Version number is missing from dist files

According to CONTRIBUTING.md, there should be a version number in the dist file after an update.

The following is done when a pull request is accepted. There is no need to do any of these steps yourself. Increment version number in src/intro.js and bower.json. Set date in src/intro.js.

Expected behavior

/**
 * @name JSON Editor
 * @description JSON Schema Based Editor
 * Deprecation notice
 * This repo is no longer maintained (see also https://github.com/jdorn/json-editor/issues/800)
 * Development is continued at https://github.com/json-editor/json-editor
 * For details please visit https://github.com/json-editor/json-editor/issues/5
 * @version 1.2.3
 * @author Jeremy Dorn
 * @see https://github.com/jdorn/json-editor/
 * @see https://github.com/json-editor/json-editor
 * @license MIT
 * @example see README.md and docs/ for requirements, examples and usage info
 */

Actual behavior

/**
 * @name JSON Editor
 * @description JSON Schema Based Editor
 * Deprecation notice
 * This repo is no longer maintained (see also https://github.com/jdorn/json-editor/issues/800)
 * Development is continued at https://github.com/json-editor/json-editor
 * For details please visit https://github.com/json-editor/json-editor/issues/5
 * @version {{ VERSION }}
 * @author Jeremy Dorn
 * @see https://github.com/jdorn/json-editor/
 * @see https://github.com/json-editor/json-editor
 * @license MIT
 * @example see README.md and docs/ for requirements, examples and usage info
 */

Steps to reproduce the behavior

Look at the header on the link to the production version or the development version on the main repro page.

About this issue

  • Original URL
  • State: closed
  • Created 6 years ago
  • Comments: 17

Commits related to this issue

Most upvoted comments

Yes, it should. When i test this task it works, but when i run “npm version 1.2.0”, which then executes the “preversion”, “version” (do the string replace) & “postversion” script in “packages.json”, it doesn’t work. I will fix it as soon as possible.

Shouldn’t the “{{ VERSION }}” marker be substituted with current version during the build process?