jquery: jquery 2.2.1 breaks webpack builds when loading individual modules
Hi,
after this change https://github.com/jquery/jquery/commit/5943f1d7ffef41cc1a99bffe189f6d111fbccfd0 webpack builds are broken when loading individual modules:
ERROR in ./~/jquery/src/selector-sizzle.js Module not found: Error: Cannot resolve 'file' or 'directory' ../external/sizzle/dist/sizzle in /Users/berto/Temp/webpack-jquery/node_modules/jquery/src @ ./~/jquery/src/selector-sizzle.js 1:0-14:3
I think this is happening because in 2.2.1 ‘selector-sizzle.js’ is trying to load the sizzle dependency as ‘…/external/sizzle/dist/sizzle’ a file which does not exist, unlike in 2.2.0 (for instance) which loads ‘sizzle’.
I set up a simple example here: https://github.com/bertez/webpack-jquery
npm install
npm run build
Thank you very much in advance.
About this issue
- Original URL
- State: closed
- Created 8 years ago
- Reactions: 3
- Comments: 19 (9 by maintainers)
Commits related to this issue
- Build: use hard-coded path to sizzle in selector-sizzle Fixes gh-2898 — committed to jquery/jquery by timmywil 8 years ago
- Release: include external/sizzle in releases Ref gh-2945 — committed to jquery/jquery by timmywil 8 years ago
- Release: include external/sizzle in releases Ref gh-2945 — committed to jquery/jquery by timmywil 8 years ago
- Release: include external/sizzle in releases Ref gh-2945 — committed to jquery/jquery by timmywil 8 years ago
- Release: copy sizzle separately into an 'external' folder Fixes gh-2945 — committed to timmywil/jquery by timmywil 8 years ago
- Release: copy sizzle separately into an 'external' folder Fixes gh-2945 — committed to timmywil/jquery by timmywil 8 years ago
- Release: copy sizzle separately into an 'external' folder Fixes gh-2945 — committed to jquery/jquery by timmywil 8 years ago
- Release: copy sizzle separately into an 'external' folder Fixes gh-2945 — committed to timmywil/jquery by timmywil 8 years ago
- Release: copy sizzle separately into an 'external' folder Fixes gh-2945 — committed to jquery/jquery by timmywil 8 years ago
- Release: copy sizzle separately into an 'external' folder Fixes gh-2945 — committed to jquery/jquery by timmywil 8 years ago
We will have a fix in the next patch. Please use GitHub’s reaction feature on the original post if you’re having the same issue.