remarkable: Adding a new HTML block to remarkable
Hello,
I am using Angular and I am trying to add https://github.com/brandly/angular-youtube-embed to remarkable so it’s capable of showing youtube videos in the github Readme.
I added this directive by adding “youtube-video” to the html_blocks object in remarkable.js but it’s still showing as plain text.
var html_blocks = {};
[
'article',
'aside',
'button',
'blockquote',
'body',
'canvas',
'caption',
'col',
'colgroup',
'dd',
'div',
'dl',
'dt',
'embed',
'fieldset',
'figcaption',
'figure',
'footer',
'form',
'h1',
'h2',
'h3',
'h4',
'h5',
'h6',
'header',
'hgroup',
'hr',
'iframe',
'li',
'map',
'object',
'ol',
'output',
'p',
'pre',
'progress',
'script',
'section',
'style',
'table',
'tbody',
'td',
'textarea',
'tfoot',
'th',
'tr',
'thead',
'ul',
'video',
'youtube-video'
].forEach(function (name) { html_blocks[name] = true; });
The directive looks like this: <youtube-video video-id="'sMKoNBRZM1M'"></youtube-video>
.
What else do I need in change to remarkable.js in order to get this working properly?
~ Archcry
About this issue
- Original URL
- State: closed
- Created 10 years ago
- Comments: 17 (7 by maintainers)
We care about standards, not about whateveranycaninvent. If you need another behaviour - write plugin, that will replace rules you are not comfortable with. Or if you don’t like commonmark spec - contact commonmark authors with your suggestions via appropriate forum. Such requests are out of this project scope.