jitsi-meet-electron: 2.1.0 breaks video on current stable releases of JM

Issue: client sees their video feed is working, but everyone else sees a black screen for the participant.

jitsi-meet 1.0.4074-1
jicofo 1.0_567-2
jitsi-videobridge 2.1_197_g38256192-1
  • Using 2.1.0 against current stable JM release(versions below) makes camera broken - Fixed in new stable JM release (4627)
    • Using a browser to connect to the same instance works just fine.
    • Using 2.1.0 to connect to meet.jit.si works just fine.
  • Using 2.1.0 P2P sometimes crashes - Worked around in 2.1.1, chromium bug.
  • Using 2.1.0 breaks on macOS due to CSP - workaround - Moved to #374
  • Using 2.1.0 or Chrome 83 with Experimental Web Platform Features enabled results in sometimes choppy/robotic audio for a participant if they have their video enabled.

About this issue

  • Original URL
  • State: closed
  • Created 4 years ago
  • Reactions: 4
  • Comments: 49 (28 by maintainers)

Commits related to this issue

Most upvoted comments

No, that’s correct. If you have p2p disabled (why would you though?) then this doesn’t apply to you.

For data-privacy-reasons. We use jitsi meet (among other things) for student application interviews and for this usecase we have the order that no external server should be involved in the process. And since we don’t have self-hosted stun servers we disabled p2p.

This is due to a bug in our use of insertable streams. We just pushed a new stable release (Docker coming tonight) which fixes that.

Ok. Just seen it and will update later. (Again: thx for your great work!)

I think things are getting confusing by the fact that there are two issues being discussed - 2.1.0/Chrome crashing due to a bug in Chromium and 2.1.0 having broken video(camera) on (now outdated) stable release.

The latter is probably fixed by a new release that got tagged an hour ago.

https://github.com/jitsi/jitsi-videobridge/releases/tag/stable%2Fjitsi-meet_4627 https://github.com/jitsi/jicofo/releases/tag/stable/jitsi-meet_4627 https://github.com/jitsi/jitsi-meet/releases/tag/stable/jitsi-meet_4627

EDIT: The black video issue was indeed fixed.

First of all: Thx for all your work and your quick response here @saghul

Technically speaking, E2EE is still in beta right? So you could release a 2.1.1 with Electron 9, but with Experimental Web Platform disabled. That would mean that E2EE will be disabled in that release, no matter which version of the server they are running.

At the same time, release a version 2.2.0-rc1 (or similar) with Electron 9 and with EWP enabled. People who want to use E2EE will need to download the 2.2 branch of releases, and people on 2.1 will continue to receive updates with the stable branch. You can tag a release in GitHub to be a pre-release.

You could even go as far as tagging this version 3.0.0, but on the other hand it is backwards compatible, so a major version bump is not correct according to semver standards.

Sounds reasonable. Also, the stable release of the client should be in sync with the stable release of the server in my opinion (not with the unstable as it is at the moment). Otherwise you would always need a compatibility-table between client and server. (Which doesn’t really work with a client which auto-updates itself).

@saghul Can you release a Version 2.1.1 with all other improvements that 2.1.0 had but disable the “Experimental Web Platform features” and release that as a beta or later when it turns stable? Thanks