eslint-plugin-jest: Typescript peer dependency should not be needed
I would like to use this plugin in a project without any typescript, why does it have a peer dependency? Going from 23.0.1 to 23.0.2 seems to have added this for me.
├─┬ eslint-plugin-jest@23.0.1
│ └─┬ @typescript-eslint/experimental-utils@2.5.0
│ ├── @types/json-schema@7.0.3
│ ├─┬ @typescript-eslint/typescript-estree@2.5.0
│ │ ├─┬ debug@4.1.1
│ │ │ └── ms@2.1.2
│ │ ├── glob@7.1.4 deduped
│ │ ├── is-glob@4.0.1 deduped
│ │ ├── lodash.unescape@4.0.1
│ │ └── semver@6.3.0 deduped
│ └── eslint-scope@5.0.0 deduped
├─┬ eslint-plugin-jest@23.0.2
│ └─┬ @typescript-eslint/experimental-utils@2.6.1
│ ├── @types/json-schema@7.0.3
│ ├─┬ @typescript-eslint/typescript-estree@2.6.1
│ │ ├─┬ debug@4.1.1
│ │ │ └── ms@2.1.2
│ │ ├── glob@7.1.5 deduped
│ │ ├── is-glob@4.0.1 deduped
│ │ ├── lodash.unescape@4.0.1
│ │ ├── semver@6.3.0
│ │ ├─┬ tsutils@3.17.1
│ │ │ └── tslib@1.10.0 deduped
│ │ └── UNMET PEER DEPENDENCY typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >=
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Reactions: 5
- Comments: 15 (6 by maintainers)
Commits related to this issue
- Update eslint util and add specific TS. The specific TS dev dep is required to have the updated eslint dep not throw any warnings. https://github.com/jest-community/eslint-plugin-jest/issues/467 — committed to danskernesdigitalebibliotek/ddb-react by lasseborly 5 years ago
- Update eslint util and add specific TS. The specific TS dev dep is required to have the updated eslint dep not throw any warnings. https://github.com/jest-community/eslint-plugin-jest/issues/467 — committed to danskernesdigitalebibliotek/ddb-react by lasseborly 5 years ago
- add typescript as a dependency, following the spec of tsutils. see commit description for WTF?! See * https://github.com/typescript-eslint/typescript-eslint/pull/1120 * https://github.com/jest-commun... — committed to ysoftwareab/eslint-plugin-y by andreineculau 3 years ago
- add typescript as a dependency, following the spec of tsutils. see commit description for WTF?! See * https://github.com/typescript-eslint/typescript-eslint/pull/1120 * https://github.com/jest-commun... — committed to ysoftwareab/eslint-plugin-y by andreineculau 3 years ago
Hello,
This also produces a warning with yarn (1.19.1) which I would like to avoid without adding a dependency to typescript.
warning "eslint-plugin-jest > @typescript-eslint/experimental-utils > @typescript-eslint/typescript-estree > tsutils@3.17.1" has unmet peer dependency "typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta".@SimenB Would moving
@typescript-eslint/experimental-utilsfromdependenciestodevDependenciesas @MatteoGabriele suggested solve it?I understand that it is safe to ignore this particular warning, however I am afraid that if we start having this kind of “safe” warnings people will simply start to ignore all warnings, so I would like to avoid them if possible.
Please open up an issue with typescript-eslint - it was added in https://github.com/typescript-eslint/typescript-eslint/pull/1120