ghprb-plugin: Pull requests are not triggered on comment triggers ( >= 1.32.4)

Having upgraded from 1.32.3 to .4 and .5, and having done a lot of extensive testing, I have found that the comment triggers no longer work. The logs clearly show that there is some difference in the paging of the comments. This behavior is observed irrespective of the value of “Only use trigger phrase for build triggering”

Here is a selected output from the log. I use the same trigger phrase for both. I have made sure that I make new comments too.

v1.32.3

Running trigger for arrayfire-linux/pr-build-tester
Jun 14, 2016 9:46:01 PM INFO org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
Pull request #17 was updated/initialized on shehzan10/arrayfire at 6/14/16 9:44 PM by Shehzan Mohammed (PR update)
Jun 14, 2016 9:46:01 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Checking for comments after: 6/14/16 9:14 PM
Jun 14, 2016 9:46:01 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Comment was made at: 6/14/16 8:46 PM
Jun 14, 2016 9:46:01 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Comment was made at: 6/14/16 9:00 PM
Jun 14, 2016 9:46:01 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Comment was made at: 6/14/16 9:03 PM
Jun 14, 2016 9:46:01 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Comment was made at: 6/14/16 9:11 PM
Jun 14, 2016 9:46:01 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Comment was made at: 6/14/16 9:14 PM
Jun 14, 2016 9:46:01 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Comment was made at: 6/14/16 9:44 PM
Jun 14, 2016 9:46:01 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Comment was made after last update time, build arrayfire linux tester ci
Jun 14, 2016 9:46:02 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
[Shehzan Mohammed] Added comment: build arrayfire linux tester ci
Jun 14, 2016 9:46:02 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Trigger phrase
Jun 14, 2016 9:46:02 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Admin User:shehzan10 ran trigger phrase
Jun 14, 2016 9:46:02 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Running the build
Jun 14, 2016 9:46:02 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
PR is not null, checking if mergable
Jun 14, 2016 9:46:02 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Running build...

v1.32.5

Running trigger for arrayfire-linux/pr-build-tester
Jun 14, 2016 10:02:00 PM INFO org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
Pull request #17 was updated/initialized on shehzan10/arrayfire at 6/14/16 10:01 PM by Shehzan Mohammed (PR update)
Jun 14, 2016 10:02:00 PM INFO org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
Pull request #17 was updated on repo shehzan10/arrayfire but there aren't any new comments nor commits; that may mean that commit status was updated.
Jun 14, 2016 10:02:00 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Trigger only phrase but we are not triggered
Jun 14, 2016 10:02:00 PM FINE org.jenkinsci.plugins.ghprb.GhprbTrigger

Just to be extra sure, I downgraded again to 1.32.3 and added a new comment trigger, and it works. You can notice the timestamps of the comments too between the 3 logs. Downgrade to v1.32.3

Running trigger for arrayfire-linux/pr-build-tester
Jun 14, 2016 10:16:01 PM INFO org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
Pull request #17 was updated/initialized on shehzan10/arrayfire at 6/14/16 10:14 PM by Shehzan Mohammed (PR update)
Jun 14, 2016 10:16:01 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Checking for comments after: 6/14/16 10:01 PM
Jun 14, 2016 10:16:01 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Comment was made at: 6/14/16 8:46 PM
Jun 14, 2016 10:16:01 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Comment was made at: 6/14/16 9:00 PM
Jun 14, 2016 10:16:01 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Comment was made at: 6/14/16 9:03 PM
Jun 14, 2016 10:16:01 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Comment was made at: 6/14/16 9:11 PM
Jun 14, 2016 10:16:01 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Comment was made at: 6/14/16 9:14 PM
Jun 14, 2016 10:16:01 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Comment was made at: 6/14/16 9:44 PM
Jun 14, 2016 10:16:01 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Comment was made at: 6/14/16 10:01 PM
Jun 14, 2016 10:16:01 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Comment was made at: 6/14/16 10:14 PM
Jun 14, 2016 10:16:01 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Comment was made after last update time, build arrayfire linux tester ci
Jun 14, 2016 10:16:01 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
[Shehzan Mohammed] Added comment: build arrayfire linux tester ci
Jun 14, 2016 10:16:01 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Trigger phrase
Jun 14, 2016 10:16:01 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Admin User:shehzan10 ran trigger phrase
Jun 14, 2016 10:16:01 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Running the build
Jun 14, 2016 10:16:01 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
PR is not null, checking if mergable
Jun 14, 2016 10:16:01 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Running build...

About this issue

Original URL
State: closed
Created 8 years ago
Reactions: 5
Comments: 18 (2 by maintainers)

Most upvoted comments

Same issue here. Appears to have broken in 1.32.4

davidkiser on Jun 15, 2016

I’m seeing this issue in 1.40.0, it sometimes takes multiple comments in order for a build to successfully start. This probably needs to be reopened.

Checking issue comment '/jenkins merge' for repo BobLobLaw/Blog
Mar 27, 2018 5:41:40 PM INFO org.jenkinsci.plugins.ghprb.GhprbGitHubAuth checkSignature
Signatures checking OK
Mar 27, 2018 5:41:40 PM INFO org.jenkinsci.plugins.ghprb.GhprbGitHubAuth checkSignature
Signatures checking OK
Mar 27, 2018 5:41:40 PM INFO org.jenkinsci.plugins.ghprb.GhprbTrigger handleComment
Checking comment on PR #2,350 for job BobLobLaw/Blog Pull Request Builder Pipeline
Mar 27, 2018 5:41:40 PM INFO org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
Pull request #2,350 was updated/initialized on BobLobLaw/Blog at 3/27/18 5:41 PM by null (comment)
Mar 27, 2018 5:41:40 PM INFO org.jenkinsci.plugins.ghprb.GhprbTrigger handleComment
Checking comment on PR #2,350 for job BobLobLaw/Merge
Mar 27, 2018 5:41:40 PM INFO org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
Pull request #2,350 was updated/initialized on BobLobLaw/Blog at 3/27/18 5:41 PM by null (comment)
Mar 27, 2018 5:41:41 PM INFO org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
Pull request #2,350 was updated on repo BobLobLaw/Blog but there aren't any new comments nor commits; that may mean that commit status was updated.
Mar 27, 2018 5:41:41 PM INFO org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
Pull request #2,350 was updated on repo BobLobLaw/Blog but there aren't any new comments nor commits; that may mean that commit status was updated.
Mar 27, 2018 5:42:01 PM INFO org.eclipse.jetty.server.session.Session beginInvalidate
Session node010xhtc8crevl21iahqjxygttct2792037 already being invalidated```

bboysca on Mar 27, 2018