jx: Missing link to preview environment URL

Summary

When we create a new PR and the preview environment is created, the link pointing to the preview environment (with anchor text ‘here’) doesn’t appear:

Screenshot-20200107155523-747x104

Steps to reproduce the behavior

Create a PR and commit changes to it.

Expected behavior

A link with preview URL with the anchor text here in the comment.

Logs

We see this in the build logs:

WARNING: Could not find the service URL in namespace **-mycompany-api-mycompany-com-pr-142 for names api.mycompany.com, preview, **-mycompany-api-mycompany-com-pr-142-preview, preview-api.mycompany.com: the server could not find the requested resource (get services.serving.knative.dev preview-api.mycompany.com)
Updating PipelineActivities mycompany-api-mycompany-com-pr-142-5 which has status Running
WARNING: Failed to find the service api.mycompany.com : failed to find service api.mycompany.com in namespace **-mycompany-api-mycompany-com-pr-142: services "api.mycompany.com" not found

Jenkins X looks for a service called api.mycompany.com but the service contains dashes instead of dots:

NAME                           TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)   AGE
service/api-mycompany-com      ClusterIP   10.100.11.26     <none>        80/TCP    18d

Seems to be related with this issue we’ve found some months ago: https://github.com/jenkins-x/jx/issues/5322

Is there some workaround to solve this?

Jx version

NAME               VERSION
jx                 2.0.1065
jenkins x platform 2.0.1737
Kubernetes cluster v1.14.9-eks-c0eccc
kubectl            v1.14.7-eks-1861c5
helm client        Client: v2.16.1+gbbdfe5e
git                2.17.1
Operating System   Ubuntu 18.04.3 LTS

Jenkins type

  • Serverless Jenkins X Pipelines (Tekton + Prow) and multiple clusters
  • Classic Jenkins

Kubernetes cluster

EKS

About this issue

  • Original URL
  • State: closed
  • Created 4 years ago
  • Comments: 20 (6 by maintainers)

Most upvoted comments

Bumping this to critical.

We are on EKS. I think we can wait a little bit more, maybe until you get BDD tests on it. But always depending on the next issue we found in the future. 😉

Thanks @jstrachan.

@marlovil I believe as part of CJXD we could create some upgrade guides. It would be very challenging to maintain the document relevant to every JX release, but since CJXD is a specific monthly JX release, it allows us to focus on specific upgrade scenarios.