jekyll-sitemap: Binary files do not inherit sitemap: false from defaults

To reproduce, create a binary file (for example .pdf) somewhere in your Jekyll site and add the following to _config.yml:

defaults:
  - scope:
      path: ""
    values:
      sitemap: false

Expected behavior: empty sitemap is generated. Actual behavior: all .md, .html, etc. files are excluded, but binary files with no front matter are included.

About this issue

Original URL
State: closed
Created 7 years ago
Comments: 15 (7 by maintainers)

Commits related to this issue

Drop github-pages gem and upgrade to Jekyll 3.5.1 Aside from the benefit of now being able to keep up with Jekyll releases as they ship, this change was prompted by the need to pick up the fix to the... — committed to bisq-network/bisq-website by cbeams 7 years ago
Set sitemap: false in defaults This change tests whether the fix in jekyll/jekyll#6162 actually addresses the problem described in jekyll/jekyll-sitemap#180, and finds that it does _not_ fix the prob... — committed to bisq-network/bisq-website by cbeams 7 years ago
Revert "Set sitemap: false in defaults" This reverts commit e643e1b5a723acc41976dca66cef98c62086e2b4. See that commit comment and jekyll/jekyll-sitemap#180 for details. — committed to bisq-network/bisq-website by cbeams 7 years ago

Most upvoted comments

Thanks everybody for all the work. This appears fixed when building site locally using latest versions of jekyll and jekyll-sitemap. I’ve made a PR to the GitHub Pages gem to update the versions, so that this carriers over to my live site as well. Assuming no surprises, I’ll close the issue at that time.

aterenin on Feb 4, 2018

Confirming that problem is NOT fixed on the master branch.

aterenin on Dec 17, 2017