node-libcurl: DNS lookups are not working with multiple system DNS servers

With the recent switch to the c-ares DNS resolver backend in version 2.3.0, it seems like DNS resolution is sometimes failing when using multiple DNS servers. A lot of our users have reported that they are unable to make requests due to this: https://github.com/Kong/insomnia/issues/3234.

Do you think it would be reasonable to stop using c-ares for the prebuilt binaries, given that there are likely a lot of other issues like this compared to the built-in system resolvers, and it’s not possible to disable it during runtime?

About this issue

Original URL
State: closed
Created 3 years ago
Reactions: 1
Comments: 15 (7 by maintainers)

Commits related to this issue

fix: do not build the prebuilt binares with c-ares as this may cause issues Closes #280 — committed to JCMais/node-libcurl by JCMais 3 years ago
:arrow_up: Bump node-libcurl to 2.3.2 to make the npm installation pass Might be linked to https://github.com/JCMais/node-libcurl/issues/280 — committed to Bernardstanislas/uptime-monitor by Bernardstanislas 3 years ago
:arrow_up: Bump node-libcurl to 2.3.2 to make the npm installation pass Might be linked to https://github.com/JCMais/node-libcurl/issues/280 — committed to namcxn/uptime-monitor by Bernardstanislas 3 years ago

Most upvoted comments

v2.3.2 has been released without c-ares.

+14

JCMais on Mar 24, 2021

Are there any special environment variables defined within the CIs that we should know about?

There are a few, please see https://github.com/JCMais/node-libcurl/blob/develop/.github/workflows/build-and-release.yaml and https://github.com/JCMais/node-libcurl/blob/develop/.appveyor.yml.

If possible, releasing a version without cares would be of great help. We use node-libcurl in our companion CLI insomnia-inso as well, so if possible having binaries for that build for the node targets as well as the electron targets too would be very appreciated.

I will do that later today or tomorrow morning, I will update this issue when it is available.

JCMais on Mar 24, 2021

Thanks @nijikokun , yep that was a typo, it was supposed to be it's now built with c-ares. It was not marked as a breaking change because I did not expect this to cause any major issues.

I will prob just remove c-ares altogether for now and wait until this is fixed.

JCMais on Mar 24, 2021