nnn: [preview-tui] updated tree breaks preview file/dir list
Environment details (Put x in the checkbox along with the information)
- Operating System: Arch Linux
- Desktop Environment: Sway
- Terminal Emulator: foot
- Shell: zsh
- Custom desktop opener (if applicable):
- Program options used:
- Configuration options set:
- Plugins are installed
- Issue exists on
nnnmaster
Arch Linux with tree 2.0.1-2, using preview-tui script, now file/dir listings don’t display correctly anymore. See [1] Running the same tree command that preview-tui uses, in a shell, it still works. See [2] Downgrading to 1.8.0-2 fixes, as expected.
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 18 (7 by maintainers)
Commits related to this issue
- don't leak inotify_fd to plugins Closes: https://github.com/jarun/nnn/issues/1291 Co-authored-by: Daniel Eklöf <daniel@ekloef.se> — committed to N-R-K/nnn by N-R-K 2 years ago
- don't leak inotify_fd to plugins Closes: https://github.com/jarun/nnn/issues/1291 Co-authored-by: Daniel Eklöf <daniel@ekloef.se> — committed to cgxxv/nnn by N-R-K 2 years ago
Kitty does loop and close FDs in the range 3-200 when exec:ing its child process.
But that means it only applies to the first shell instance; when nnn runs, and when nnn exec’s a plugin, kitty is not involved in the process, and no FDs are closed. Unless nnn spawns a new kitty instance when you start a shell from it (it doesn’t for me).
No worries, and I hope I didn’t come off as being rude. The bash script was only meant as a way to show/prove that the leaked FD is the cause, and I could have been more clear about that.