mustache.js: Custom delimiters on Mustache.parse() not working since 2.3.1
Since version 2.3.1 custom delimiters apparently don’t work anymore for Mustache.parse(). See the following examples:
- 2.3.0, working, values are inserted: https://codepen.io/mbrodala/pen/vaQPxK
- 2.3.1: broken, values are not inserted: https://codepen.io/mbrodala/pen/NBEJjX
This is most likely related to #663 and its fix. Notice that I can restore this by using the newer Mustache.tags = [...] instead: https://codepen.io/mbrodala/pen/QBJoOx
Can you please have a look at this?
About this issue
- Original URL
- State: closed
- Created 6 years ago
- Reactions: 1
- Comments: 16 (8 by maintainers)
Commits related to this issue
- [TASK] Reliably override Mustache tags See https://github.com/janl/mustache.js/issues/669 — committed to pagemachine/searchable by mbrodala 6 years ago
- Fix custom tags by rolling back #643 & #664 (#670) Pull requests #643 and #664 together fix the issue reported in issue #617, but the change in behavior is causing semvers concerns. See issue #669. T... — committed to norfish/mustache.js by raymond-lam 6 years ago
Hats off to @raymond-lam for this one! Thanks to you as well, crucial for us to know when unexpected changes happens out in the wild.
v2.3.2 has been published 🚀
Thanks a lot for looking into and fixing this, you guys rock. 👍
Sounds off and basically is but will fix this issue while keeping the fix intact. OK from my POV.